Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump bevy to 0.13 #38

Merged
merged 1 commit into from
Feb 20, 2024
Merged

feat: bump bevy to 0.13 #38

merged 1 commit into from
Feb 20, 2024

Conversation

liquidhelium
Copy link
Contributor

@liquidhelium liquidhelium commented Feb 19, 2024

Maybe I should update the version number?

Cargo.toml Outdated Show resolved Hide resolved
@umut-sahin
Copy link
Owner

Thanks for the PR, I was planning to do it myself this week, and it's a nice surprise!

Could you please revert adding all feature to default features and update the commit message to:

feat: bump bevy to v0.13

I'll start the CI and merge the PR once CI is green afterwards. Thanks!

@umut-sahin
Copy link
Owner

You don't need to worry about the version, I'll bump it before release. Lastly, I'd love to add you as a contributor, if you provide me your NAME <EMAIL> like in:

authors = [
    "Umut Şahin <[email protected]>",
    "Shane Lillie <[email protected]>",
    "Eri Pazos <[email protected]>",
    "Scott Godwin <[email protected]>",
]

@liquidhelium liquidhelium changed the title feat: update to bevy 0.13 feat: bump bevy to 0.13 Feb 20, 2024
@liquidhelium
Copy link
Contributor Author

I prefer to keep my real name as a secret, so I'm not sure if my pseudonym can be used here.

"Helium <[email protected]>"

@umut-sahin
Copy link
Owner

Of course, I'll update the list of authors as you wish 👍

Please squash the two commits in this PR, second one just reverts a part of the first one, it can be kept unmodified in the first place.

Thanks!

@liquidhelium
Copy link
Contributor Author

Awesome, done!

@umut-sahin umut-sahin merged commit 09b36ee into umut-sahin:main Feb 20, 2024
7 checks passed
@umut-sahin
Copy link
Owner

v0.5.0 released https://crates.io/crates/bevy-persistent/0.5.0 with Bevy v0.13 support 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants