Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SonarQube. #1265

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add SonarQube. #1265

wants to merge 2 commits into from

Conversation

superzaky
Copy link
Contributor

No description provided.

@superzaky superzaky requested a review from fhoeben February 21, 2020 22:35
@fhoeben
Copy link
Collaborator

fhoeben commented Feb 21, 2020

What does this get us, can we now get a report about the code quality? How/where?

@fhoeben
Copy link
Collaborator

fhoeben commented Feb 26, 2020

Thanks for adding a description of what to do. It is (of course) specific to people running Windows, but I believe it would be easily adjusted for other OSs.
The remark about skipping the unit test throws me off a bit. I would expect that one would also run all tests (jUnit and FitNesse.AcceptanceSuite) and see their coverage in Sonar.

Having said that. I don't plan to run Sonar locally to track issues this way and without guidelines exactly what should be done with the output/report in Sonar I don't see other people picking it up and using it as part of a regular regime contributing to the project. So I don't see much added value in merging this PR in at the moment.

This is not to say you cannot run Sonar locally this way, use it to find issues and then submit PRs addressing those. PRs addressing issues are greatly appreciated and if you find them using Sonar and have time to address them that's great. Or even if you just create issue reports based for things you find that would already be great also.

When it turns out we can prevent many problems in future by running this analysis regularly (before each release, on each PR?) incorporating it into the regular routine and guidelines would be a logical step. But for me it is not at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants