[test] #137 implement newVoteReceived event on Fund contract

[jorgezerpa]

Pull Request

• Closes [feat] Emit event when fund receives a vote #137
• Added tests (if necessary) -> none
• Run tests -> none
• Run formatting -> none
• Commented the code -> none

Changes description

• create an event NewVoteReceived in the Fund contract
• Emit such event when call receiveVote function

Current output

Time spent breakdown

1 hour

Comments

I'm happy to contribute! I stay attentive to any feedback or needed modification

[EmmanuelAR]

Hello @jorgezerpa thanks for the pr, so fast, there are some changes request. Thks again!

[jorgezerpa]

Hello @EmmanuelAR I got it!🫡 I'll try to get it done by tomorrow before half of the day🚀

[EmmanuelAR]

Take your time Sr!

[jorgezerpa]

GM! changes ready:

Just 2 things before make the push:

1. When I access to "self.up_votes.read()" should I add 1 on the event? (like "self.up_votes.read() + 1") or with the line "self.up_votes.write(self.up_votes.read() + 1);" that is above in the same function the value is already added when I try to read it again?
2. Check the name of the keys, let me know if are OK or maybe you would like to change someone

[EmmanuelAR]

Hey @jorgezerpa

1. For the votes just call the votes.read() because we already increment it.
2. I cant check the name of the keys because you have to push the code
3. please run scarb fmt

[jorgezerpa]

@EmmanuelAR pushed!🙌

[EmmanuelAR]

Exc work @jorgezerpa LGTM!

[EmmanuelAR]

hey @jorgezerpa please merge your local branch with the latest version of the code, we add some events so the event trait is already create and you are adding twice fix like this example:

Also run scarb build and fmt

[jorgezerpa]

@EmmanuelAR Merged, fixed and pushed🫡