Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Refactor navBarItems #166

Merged
merged 1 commit into from
Oct 28, 2024
Merged

[fix] Refactor navBarItems #166

merged 1 commit into from
Oct 28, 2024

Conversation

Benjtalkshow
Copy link
Contributor

@Benjtalkshow Benjtalkshow commented Oct 27, 2024 •
edited
Loading

Fixes #163

  • Closes

  • Created a single navItems constant in constants/index.ts

  • Updated each page component to import navItems from constants/index.ts

  • Thoroughly tested the refactored navigation to confirm that it functions consistently across all pages.

Thanks for the opportunity to contribute to this project.

@adrianvrj adrianvrj self-requested a review October 28, 2024 20:03
adrianvrj
adrianvrj approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@adrianvrj adrianvrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@adrianvrj adrianvrj merged commit 2e062d0 into undefinedorgcr:dev Oct 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianvrj adrianvrj adrianvrj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] Refactor navBarItems
2 participants
@Benjtalkshow @adrianvrj