Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add donators contract tests #50

Merged
merged 2 commits into from
Aug 27, 2024
Merged

[feat] Add donators contract tests #50

merged 2 commits into from
Aug 27, 2024

Conversation

EmmanuelAR
Copy link
Collaborator

  1. Add new backend readme
  2. Add snforge_std and openzeppelin dependencies in scarb.toml
  3. Make IDonator trait public
  4. fix updateDonatorValues method because the total_stark_donations was not updated
  5. make all the modules public in lib.cairo
  6. Add donator tests

closes #42
Captura de pantalla 2024-08-26 a la(s) 10 27 48 p  m
Captura de pantalla 2024-08-26 a la(s) 10 28 22 p  m

@EmmanuelAR
Changes:
4515731 
1.  Add new backend readme
2. Add snforge_std and openzeppelin dependencies in scarb.toml
3. Make IDonator trait public
4. fix updateDonatorValues method because the total_stark_donations was not updated
5. make all the modules public in lib.cairo
6. Add donator tests
@EmmanuelAR EmmanuelAR requested a review from adrianvrj August 27, 2024 04:28
@adrianvrj adrianvrj changed the title Changes [feat] Add donators contract tests Aug 27, 2024
@adrianvrj adrianvrj self-assigned this Aug 27, 2024
@adrianvrj
Copy link
Member

just a single comment, great job

adrianvrj
adrianvrj approved these changes Aug 27, 2024
View reviewed changes
contracts/README.md Outdated
scarb build
3. **Run gostarkme unit test ✅**
```bash
snforce test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snforge*

@adrianvrj adrianvrj merged commit 8a9d095 into undefinedorgcr:main Aug 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianvrj adrianvrj adrianvrj approved these changes

Assignees

@adrianvrj adrianvrj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing Donators contract
2 participants
@EmmanuelAR @adrianvrj