[UNDERTOW-2404] Add default sorting by type and name in directory lis… #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xjusko
force-pushed
the
UNDERTOW-2404
branch
from
d669b70 to
fe9818b
Compare
baranowb
added
enhancement
baranowb
requested changes
Sep 4, 2024
|
|
||
| int state = 0; | ||
| String parent = getParentPath(path, state); | ||
|
|
||
| SimpleDateFormat format = new SimpleDateFormat("MMM dd, yyyy HH:mm:ss", Locale.US); |
There was a problem hiding this comment.
Why? Its an enhancement, lets improve and ditch imperials( or possibly Locale.getDefault() and make decision based on this info?
| Comparator<Resource> comparator; | ||
| if ("lastModified".equals(sortColumn)) { | ||
| comparator = Comparator.comparing( | ||
| entry -> (entry.getLastModified() == null) ? new Date(0L) : entry.getLastModified() |
There was a problem hiding this comment.
if its somehow possible, maybe just use creation date rather than 1970 ?
There was a problem hiding this comment.
There is no creation date, but I think using a string like Unknown or Not Available. What do you think?
There was a problem hiding this comment.
It makes sense to me. As we sure that it is possible to get a null here? Maybe we even want to have something like: "-"
Such as: last modified: -
xjusko
force-pushed
the
UNDERTOW-2404
branch
from
fe9818b to
b887985
Compare
fl4via
requested changes
Sep 18, 2024
| Comparator<Resource> comparator; | ||
| if ("lastModified".equals(sortColumn)) { | ||
| comparator = Comparator.comparing( | ||
| entry -> (entry.getLastModified() == null) ? new Date(0L) : entry.getLastModified() |
There was a problem hiding this comment.
It makes sense to me. As we sure that it is possible to get a null here? Maybe we even want to have something like: "-"
Such as: last modified: -
fl4via
removed
the
waiting peer review
xjusko
force-pushed
the
UNDERTOW-2404
branch
2 times, most recently
from
eb1c957 to
6b4575f
Compare
…ting view; enable clickable name and size column headers for custom sorting
fl4via
approved these changes
Oct 4, 2024
baranowb
approved these changes
Oct 4, 2024
fl4via
removed
the
under verification
baranowb
added
the
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ting view; enable clickable name and size column headers for custom sorting
https://issues.redhat.com/browse/UNDERTOW-2404