-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UNDERTOW-2462] adds DEFAULT_ALLOW_ENCODED_SLASH #1677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! Please add the issue number to the the commit messages like this [UNDERTOW-2462],and there is a comment that needs to be updated in the Javadoc.
@@ -112,13 +112,18 @@ public class UndertowOptions { | |||
*/ | |||
public static final Option<Integer> MAX_COOKIES = Option.simple(UndertowOptions.class, "MAX_COOKIES", Integer.class); | |||
|
|||
/** | |||
* Default value of {@link #ALLOW_EQUALS_IN_COOKIE_VALUE} option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEFAULT_ALLOW_ENCODED_SLASH. Please update the comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
@ChandanaRao13 to quickly edit the commit messages of the last two commits do |
b39408b
to
0a60ecb
Compare
This adds a default value for ALLOW_ENCODED_SLASH.
https://issues.redhat.com/browse/UNDERTOW-2462