Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNDERTOW-2518] At WebSocketTimeoutTestCase, use a longer watch timeout #1694

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

fl4via
Copy link
Member

@fl4via fl4via commented Oct 20, 2024

@fl4via fl4via added enhancement Enhances existing behaviour or code next release This PR will be merged before next release or has already been merged (for payload double check) waiting CI check Ready to be merged but waiting for CI check labels Oct 20, 2024
@fl4via
Copy link
Member Author

fl4via commented Oct 20, 2024

Testing if increasing the watch timeout makes the error goes away

@fl4via fl4via marked this pull request as ready for review October 21, 2024 02:52
…foreServerStarts and @AfterServerStops for simpler before and after methods

Signed-off-by: Flavia Rainone <[email protected]>
…ut to verify if the timeout is working, and increase the interval of tolerance for the time spent

This may work better on slower machines when running this test.

Signed-off-by: Flavia Rainone <[email protected]>
@fl4via fl4via removed the waiting CI check Ready to be merged but waiting for CI check label Oct 21, 2024
@fl4via fl4via merged commit a2724f4 into undertow-io:main Oct 21, 2024
13 of 16 checks passed
@fl4via fl4via deleted the UNDERTOW-2518 branch October 21, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances existing behaviour or code next release This PR will be merged before next release or has already been merged (for payload double check)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant