[TASK] add better exception and use default value to avoid breaking DI

undkonsorten · Dec 9, 2024 · 6086e46 · 6086e46
1 parent 94072e2
commit 6086e46
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/Classes/Configuration/CommandLineInterfaceConfigurationManager.php b/Classes/Configuration/CommandLineInterfaceConfigurationManager.php
@@ -77,7 +77,7 @@ public function __construct(
         private FrontendTypoScriptFactory $frontendTypoScriptFactory,
         private ConnectionPool $connectionPool,
         private SetRegistry $setRegistry,
-        private string $siteIdentifier,
+        private string $siteIdentifier = '',
     ) {}
 
     /**
@@ -274,10 +274,12 @@ private function getCachedCurrentPageId(): int
      */
     private function getCurrentPageId(): int
     {
+        if($this->siteIdentifier === ''){
+            throw new \Exception('There is not site identifier provided. Please provide one via Service.yaml or Service.php. Read README.md for more help.', 1731170914);
+        }
         $site = $this->siteFinder->getSiteByIdentifier($this->siteIdentifier);
         if ($site instanceof NullSite) {
-            // @TODO better exception
-            throw new \Exception('Neine hier', 1731170913);
+            throw new \Exception('The site with identifier '.$this->siteIdentifier.' can not be found', 1731170913);
         }
         return $site->getRootPageId();
     }