Merge pull request #166 from unexpectedjs/tech/asyncApplyFixes

Make `applyFixes` async to avoid `prettyMaybe.sync`
unexpectedjs · Jan 23, 2024 · e15e461 · e15e461
2 parents 164bcc6 + 46c0912
commit e15e461
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/.prettierrc b/.prettierrc
@@ -1,3 +1,4 @@
 {
-  "singleQuote": true
+  "singleQuote": true,
+  "trailingComma": "es5"
 }
diff --git a/lib/applyFixes.js b/lib/applyFixes.js
@@ -185,7 +185,7 @@ function fixUnassessed(
   return fixes;
 }
 
-function applyFixes(fixes) {
+async function applyFixes(fixes) {
   const fixesByFileName = {};
   let numFixedExpects = 0;
   for (const fix of fixes) {
@@ -254,7 +254,7 @@ function applyFixes(fixes) {
       if (
         !/^(?:0|false|off|no)$/.test(process.env.UNEXPECTED_SNAPSHOT_PRETTIER)
       ) {
-        fixedCode = prettyMaybe.sync(fileName, fixedCode, {
+        fixedCode = await prettyMaybe(fileName, fixedCode, {
           requireConfig: false,
         });
       }

diff --git a/lib/unexpected-snapshot-update.js b/lib/unexpected-snapshot-update.js
@@ -15,7 +15,7 @@ function ensureAfterHookIsRegistered() {
   afterBlockRegistered = true;
   after(async function () {
     const { numFixedExpects, fixedSourceTextByFileName } =
-      applyFixes(topLevelFixes);
+      await applyFixes(topLevelFixes);
 
     const fileNames = Object.keys(fixedSourceTextByFileName);
 

diff --git a/package.json b/package.json
@@ -50,7 +50,7 @@
     "mocha": "^8.0.1",
     "nyc": "^15.0.0",
     "offline-github-changelog": "^2.0.0",
-    "prettier": "~2.5.0",
+    "prettier": "~3.2.4",
     "rollup": "^2.0.3",
     "rollup-plugin-commonjs": "^10.0.0",
     "rollup-plugin-json": "^4.0.0",