Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshots of the welcome page #1971

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

networkException
Copy link
Member

@networkException networkException commented May 30, 2022

This pull request adds two screenshots of the browser of the welcome page to be
used by different platforms, for example as images in app stores.
See flathub/com.github.Eloston.UngoogledChromium#59

@networkException networkException changed the title Add screenshot of the about page Add screenshots of the about page May 30, 2022
@networkException
Copy link
Member Author

Even though the images contain version information I wouldn't update them unless there's a significant change to the ui to avoid increasing the repository size that much

@PF4Public
Copy link
Contributor

But that is essentially the same image as vanilla Chromium save for the "ungoogled-chromium" text O.o

@networkException
Copy link
Member Author

I guess it shows objective 2 😄

If you have a better aspect to show in such a screenshot I'll happily adjust

@Ahrotahn
Copy link
Contributor

Are there any requirements to show the version in the screenshot? Maybe a good alternative would be chrome://flags since the look of that page hardly ever changes and it would still show off the light and dark themes well.

@networkException
Copy link
Member Author

Nope no requirement

chrome://flags is a good idea I think, I'll update the pr later in the evening

@PF4Public
Copy link
Contributor

PF4Public commented May 30, 2022

chrome://flags is a good idea I think

Maybe even filtered by ungoogled-chromium? Although, I do not know, what would it prove :)

Ahrotahn
Ahrotahn previously approved these changes Jun 21, 2022
Copy link
Contributor

@Ahrotahn Ahrotahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had approved this already, sorry @networkException!
I see no problem with adding the screenshots. We can always update them if they need to be changed.

@networkException
Copy link
Member Author

I quite like the idea of screenshotting the welcome page, maybe we'll just wait

@PF4Public
Copy link
Contributor

@networkException This PR is no longer blocked ;)

@networkException
Copy link
Member Author

oh right 😅

@networkException networkException requested a review from a team as a code owner June 24, 2023 00:51
@networkException networkException changed the title Add screenshots of the about page Add screenshots of the welcome page Jun 24, 2023
This patch adds two screenshots of the browser of the welcome page to be
used by different platforms, for example as images in app stores.

See flathub/com.github.Eloston.UngoogledChromium#59
@PF4Public
Copy link
Contributor

PF4Public commented Jun 24, 2023

Could be a nitpick, but still, perhaps make them narrower? Who needs all this empty space left and right…

Also, maybe docs would be better place for them?

@networkException
Copy link
Member Author

networkException commented Jun 28, 2023

sure, how narrow though? I thought I'd stick to roughly 16:9

@PF4Public
Copy link
Contributor

PF4Public commented Jun 29, 2023

Just narrow enough for everything to fit and have (subjectively :D) pleasant margins.
Something like this:
image

Also maybe it would make positive difference if making screenshot on a hidpi screen :D

Copy link
Contributor

@Ahrotahn Ahrotahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it just depends on how you want the images to look on the page. I'm fine with either version. If you think we might ever someday include another screenshot then maybe we should make an image/screenshot subdirectory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants