-
Notifications
You must be signed in to change notification settings - Fork 852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add screenshots of the welcome page #1971
base: master
Are you sure you want to change the base?
Add screenshots of the welcome page #1971
Conversation
8b25d30
to
55fd81b
Compare
Even though the images contain version information I wouldn't update them unless there's a significant change to the ui to avoid increasing the repository size that much |
But that is essentially the same image as vanilla Chromium save for the "ungoogled-chromium" text O.o |
I guess it shows objective 2 😄 If you have a better aspect to show in such a screenshot I'll happily adjust |
Are there any requirements to show the version in the screenshot? Maybe a good alternative would be |
Nope no requirement
|
Maybe even filtered by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I had approved this already, sorry @networkException!
I see no problem with adding the screenshots. We can always update them if they need to be changed.
I quite like the idea of screenshotting the welcome page, maybe we'll just wait |
@networkException This PR is no longer blocked ;) |
oh right 😅 |
55fd81b
to
1c518aa
Compare
This patch adds two screenshots of the browser of the welcome page to be used by different platforms, for example as images in app stores. See flathub/com.github.Eloston.UngoogledChromium#59
1c518aa
to
05cb647
Compare
Could be a nitpick, but still, perhaps make them narrower? Who needs all this empty space left and right… Also, maybe |
sure, how narrow though? I thought I'd stick to roughly 16:9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it just depends on how you want the images to look on the page. I'm fine with either version. If you think we might ever someday include another screenshot then maybe we should make an image/screenshot subdirectory.
This pull request adds two screenshots of the browser of the welcome page to be
used by different platforms, for example as images in app stores.
See flathub/com.github.Eloston.UngoogledChromium#59