Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default WebRTC policy, add default settings documentation #2359

Merged
merged 2 commits into from
Jun 10, 2023

Conversation

Ahrotahn
Copy link
Contributor

This PR sets the WebRTC IP handling policy to disable non-proxied UDP by default. This also introduces new documentation for the default settings changed by ungoogled-chromium.

The WebRTC IP handling policy can be changed with the existing --webrtc-ip-handling-policy switch and #1687 adds an entry in chrome://flags.

This default may no longer be necessary if mDNS is re-enabled in #2116.

@Ahrotahn Ahrotahn requested a review from a team as a code owner May 23, 2023 14:57
Copy link
Member

@networkException networkException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, I think these could be separate commits, all good otherwise

@Ahrotahn
Copy link
Contributor Author

I'm not sure why I didn't make them separate commits in retrospect.

@PF4Public
Copy link
Contributor

Do I get it right: it is supposed to supersede #1845 and it is a part it it?

Will we be dealing with licensing demarcation somehow someday?

@Ahrotahn
Copy link
Contributor Author

Ahrotahn commented Jun 7, 2023

Yup! This shouldn't run into any licensing issues as far as I'm aware.

@Ahrotahn Ahrotahn linked an issue Jun 7, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebRTC still leaks the local IP of users
3 participants