Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

third-third-party binaries #2472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −0
Open

third-third-party binaries #2472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/bugreport.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ body:
label: Installed
description: How was ungoogled-chromium installed on your OS/Platform
options:
- chrlauncher, woolyss, marmaduke, winchrome, macchrome, linchrome
- Compiled from source
- OS/Platform's package manager
- Flatpak
Expand Down
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ If your operating system is not listed above, you can also try to [**Download bi

These binaries are known as **contributor binaries**.

Please note that no support will be provided for binaries obtained outside of [ungoogled-software](https://github.com/ungoogled-software) GitHub organisation. Usage of `chrlauncher` is also discouraged.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binaries referenced in https://github.com/ungoogled-software/ungoogled-chromium-binaries are a bit of a gray area I guess (with very few, like the Windows ones built using GitHub Actions being supported). How about

Suggested change
Please note that no support will be provided for binaries obtained outside of [ungoogled-software](https://github.com/ungoogled-software) GitHub organisation. Usage of `chrlauncher` is also discouraged.
Please note that no support will be provided for these **contributor binaries** as well as all other binaries obtained outside of the [ungoogled-software](https://github.com/ungoogled-software) GitHub organisation. Usage of `chrlauncher` is also discouraged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you mentioned that! While writing this sentence it occurred to me that the gist of a problem with third-party binaries is the lack of convenience. Indeed people want to use ungoogled-chromium and enjoy convenient updates. Agreed, this sounds as if one wants to have one's cake and eat it. That being said if we reject any support for every binary, what's left for end-user? Build from source — inconvenient! Switch to more supported [by ungoogled-chromium] Linux distribution — inconvenient! Yeah, it diverts more into philosophical realm, but I'd be happy to hear your take on this dilemma.

This comment was marked as off-topic.

Sign in to view

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think another problem with the binaries listed at https://ungoogled-software.github.io/ungoogled-chromium-binaries is that many of them are extremely outdated. If a user comes for help with their Ungoogled Chromium installation stuck 30 versions behind, is there really any support they can receive (other then being recommended to use a different variant available for their OS, if it even exists)?

I think it may be beneficial to somehow clearly mark which binaries are up-to-date and supported, and which are obsolete and shouldn't really be used until they are maintained again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I'd be happy to hear your take on this dilemma.

@networkException

Copy link
Member

@networkException networkException Nov 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear much of this is future work, eventually I'd like to just drop anything that isn't build by CI in one of the platform repos in the main org and let that be it. So then its everything "we" as in anyone that got "approved" by the core team to work on binaries publish is getting support, everything else not

This might still be inconvenient for platforms we dont maintain but this is the only middle ground I can think of between our current unfortunate situation with a lot of support requests for random stuff we don't have control over and only supporting source builds

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you're still in support of excluding contributor binaries from being named as supported ones, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, although currently I guess its not clear to end users that Windows binaries are compiled by CI and wouldn't count as such.


## Source Code

This repository only contains the common code for all platforms; it does not contain all the configuration and scripts necessary to build ungoogled-chromium. Most users will want to use platform-specific repos, where all the remaining configuration and scripts are provided for specific platforms:
Expand Down