Skip to content

Commit

Permalink
[DSC-1650] fix showLabel flag after merge
Browse files Browse the repository at this point in the history
  • Loading branch information
alisaismailati committed Jul 29, 2024
1 parent 7fe191d commit 44e69cf
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

<ng-container *ngSwitchDefault>
<ds-themed-default-browse-elements
[showMetrics]="showMetrics"
[showThumbnails]="topSection.showThumbnails"
[topSection]="topSection"
[showLabel]="showLabel"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ export class BrowseMostElementsComponent implements OnInit, OnChanges {
@Input() paginatedSearchOptions: PaginatedSearchOptions;

@Input() context: Context;
/**
* Whether to show the badge label or not
*/
@Input() showLabel: boolean;

showLabel: boolean;

showMetrics = true;

@Input() topSection: TopSection;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
[listID]="paginatedSearchOptions.configuration"
[object]="object"
[showMetrics]="showMetrics"
[showLabel]="showLabel"
[showThumbnails]="showThumbnails"
[viewMode]="paginatedSearchOptions.view"></ds-listable-object-component-loader>
</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,7 @@ export class DefaultBrowseElementsComponent extends AbstractBrowseElementsCompon
*/
@Input() showThumbnails = this.appConfig.browseBy.showThumbnails;

@Input() showLabel: boolean;

protected followThumbnailLink = true;
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ export class ThemedDefaultBrowseElementsComponent extends ThemedComponent<Defaul

@Input() showThumbnails: boolean;

protected inAndOutputNames: (keyof DefaultBrowseElementsComponent & keyof this)[] = ['paginatedSearchOptions', 'context', 'topSection', 'showMetrics', 'showThumbnails'];
@Input() showLabel: boolean;

protected inAndOutputNames: (keyof DefaultBrowseElementsComponent & keyof this)[] = ['paginatedSearchOptions', 'context', 'topSection', 'showMetrics', 'showThumbnails', 'showLabel'];

protected getComponentName(): string {
return 'DefaultBrowseElementsComponent';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ export class ThemedBrowseMostElementsComponent extends ThemedComponent<BrowseMos

@Input() topSection: TopSection;

@Input() showLabel: boolean;

protected inAndOutputNames: (keyof BrowseMostElementsComponent & keyof this)[] = ['context', 'paginatedSearchOptions', 'topSection', 'showLabel'];
protected inAndOutputNames: (keyof BrowseMostElementsComponent & keyof this)[] = ['context', 'paginatedSearchOptions', 'topSection'];

protected getComponentName(): string {
return 'BrowseMostElementsComponent';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div *ngIf="topSection.titleKey" class="card-header">{{ 'explore.index.' + topSection.titleKey | translate }}</div>
<div *ngIf="!topSection.titleKey" class="card-header">{{ 'explore.index.' + topSection.sortField | translate }}</div>
<div class="card-body p-0">
<ds-themed-browse-most-elements [context]="context" [paginatedSearchOptions]="paginatedSearchOptions" [topSection]="topSection" [showLabel]="showLabel"></ds-themed-browse-most-elements>
<ds-themed-browse-most-elements [context]="context" [paginatedSearchOptions]="paginatedSearchOptions" [topSection]="topSection"></ds-themed-browse-most-elements>
</div>
</div>
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ export class TopSectionComponent implements OnInit {

paginatedSearchOptions: PaginatedSearchOptions;

showLabel: boolean;

ngOnInit() {
const order = this.topSection.order;
const numberOfItems = this.topSection.numberOfItems;
Expand Down

0 comments on commit 44e69cf

Please sign in to comment.