Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICU4X 1.5 #239

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run-rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
icu4x-version: [ '1.3', '1.4' ]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icu4x- version: [ '1.3' , '1.4' ]

icu4x-version: [ '1.3', '1.4', '1.5' ]
name: Lint the executor code for ICU4X
runs-on: ubuntu-latest
steps:
Expand Down
38 changes: 0 additions & 38 deletions executors/rust/1.3/src/decimalfmt.rs

This file was deleted.

27 changes: 0 additions & 27 deletions executors/rust/1.3/src/displaynames.rs

This file was deleted.

6 changes: 3 additions & 3 deletions executors/rust/1.3/src/langnames.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

use serde_json::{json, Value};

use icu::displaynames::{DisplayNamesOptions, LanguageDisplayNames};
use crate::icu::experimental::displaynames::{DisplayNamesOptions, LanguageDisplayNames};

use icu::locid::subtags::Language;
use icu::locid::Locale;
use crate::icu::locid::subtags::Language;
use crate::icu::locid::Locale;

// Function runs language names tests
pub fn run_language_name_test(json_obj: &Value) -> Result<Value, String> {
Expand Down
10 changes: 8 additions & 2 deletions executors/rust/1.3/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,20 @@
// https://unicode-org.github.io/icu4x-docs/doc/icu_collator/index.html

mod collator;
mod decimalfmt;
mod displaynames;
mod langnames;
mod likelysubtags;
mod listfmt;
mod numberfmt;
mod pluralrules;

mod icu {
pub mod experimental {
pub use icu::compactdecimal;
pub use icu::displaynames;
}
pub use icu::locid;
}

use collator::run_collation_test;
use langnames::run_language_name_test;
use likelysubtags::run_likelysubtags_test;
Expand Down
2 changes: 1 addition & 1 deletion executors/rust/1.3/src/numberfmt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use fixed_decimal::SignDisplay;
use icu::decimal::options;
use icu::decimal::FixedDecimalFormatter;

use icu::compactdecimal::CompactDecimalFormatter;
use crate::icu::experimental::compactdecimal::CompactDecimalFormatter;

use icu::locid::{extensions::unicode::key, Locale};

Expand Down
Loading
Loading