Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22956 Use InCB for grapheme cluster segmentation #3257

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Oct 29, 2024

Fix grapheme cluster segmentation, which had gone out of synch with the Unicode Standard because the derivation of InCB had changed in 16.0.

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22956
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

macchiati
macchiati previously approved these changes Oct 29, 2024
@eggrobin
Copy link
Member Author

eggrobin commented Nov 5, 2024

@markusicu I think this one will need byte flipping too.

@markusicu markusicu self-assigned this Nov 5, 2024
@markusicu
Copy link
Member

@markusicu I think this one will need byte flipping too.

done

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu
Copy link
Member

@eggrobin this looks ready to merge; please do so unless you discovered something else to change

@eggrobin
Copy link
Member Author

Yeah, it is ready, I just got distracted by a UTC meeting.

@eggrobin eggrobin merged commit 0b9eb9c into unicode-org:main Nov 12, 2024
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants