Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22977 Fix MSVC builds #3276

Closed
wants to merge 1 commit into from
Closed

ICU-22977 Fix MSVC builds #3276

wants to merge 1 commit into from

Conversation

mihnita
Copy link
Contributor

@mihnita mihnita commented Nov 21, 2024

Temporarily remove the Universal Windows Platform (_wup) projects.

Checklist

  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22977
    • For minor changes you can use one of the following per-release tickets:
    • ICU 77 code warnings/version updates: ICU-22920 — Fix compiler warnings. Update versions of code-related dependencies (e.g., dependabot).
    • ICU 77 docs minor fixes: ICU-22921 — User Guide & API docs typos etc., and version updates (e.g., dependabot for User Guide)
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/allinone/allinone.sln is no longer changed in the branch
  • icu4c/source/common/common_uwp.vcxproj is now changed in the branch
  • icu4c/source/data/makedata_uwp.vcxproj is now changed in the branch
  • icu4c/source/i18n/i18n_uwp.vcxproj is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/common_uwp.vcxproj is different
  • icu4c/source/data/makedata_uwp.vcxproj is different
  • icu4c/source/i18n/i18n_uwp.vcxproj is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/allinone/allinone.sln is now changed in the branch
  • icu4c/source/common/common_uwp.vcxproj is no longer changed in the branch
  • icu4c/source/data/makedata_uwp.vcxproj is no longer changed in the branch
  • icu4c/source/i18n/i18n_uwp.vcxproj is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@mihnita mihnita marked this pull request as draft November 21, 2024 10:26
@mihnita mihnita closed this Nov 21, 2024
@mihnita mihnita deleted the mihai_fix_win_build branch November 21, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant