fix module path

.gitignore

@@ -1,3 +1,5 @@
 *.tfstate*
 .terraform/
 spec/reports/*
+
+.idea/

group/asg/main.tf

@@ -5,13 +5,13 @@ locals {
   default_asg_tags = [
     {
       key                 = "application"
-      value               = "${var.stack_item_fullname}"
+      value               = var.stack_item_fullname
       propagate_at_launch = true
     },
     {
       key                 = "Name"
-      value               = "${length(var.asg_name_override) > 0 ? var.asg_name_override : var.stack_item_label}"
-      propagate_at_launch = "${var.propagate_name_at_launch}"
+      value               = length(var.asg_name_override) > 0 ? var.asg_name_override : var.stack_item_label
+      propagate_at_launch = var.propagate_name_at_launch
     },
     {
       key                 = "managed_by"
@@ -22,54 +22,55 @@ locals {
 }
 
 resource "aws_autoscaling_group" "asg" {
-  count = "${length(var.min_elb_capacity) > 0 || length(var.wait_for_elb_capacity) > 0 ? 0 : 1}"
+  count = length(var.min_elb_capacity) > 0 || length(var.wait_for_elb_capacity) > 0 ? 0 : 1
 
-  default_cooldown          = "${length(var.default_cooldown) > 0 ? var.default_cooldown : "300"}"
-  desired_capacity          = "${length(var.desired_capacity) > 0 ? var.desired_capacity : var.min_size}"
-  enabled_metrics           = ["${compact(var.enabled_metrics)}"]
-  force_delete              = "${var.force_delete}"
-  health_check_grace_period = "${length(var.hc_grace_period) > 0 ? var.hc_grace_period : "300"}"
+  default_cooldown          = length(var.default_cooldown) > 0 ? var.default_cooldown : "300"
+  desired_capacity          = length(var.desired_capacity) > 0 ? var.desired_capacity : var.min_size
+  enabled_metrics           = compact(var.enabled_metrics)
+  force_delete              = var.force_delete
+  health_check_grace_period = length(var.hc_grace_period) > 0 ? var.hc_grace_period : "300"
   health_check_type         = "EC2"
-  launch_configuration      = "${var.lc_id}"
-  max_size                  = "${var.max_size}"
-  metrics_granularity       = "${var.metrics_granularity}"
-  min_size                  = "${var.min_size}"
-  name                      = "${length(var.asg_name_override) > 0 ? var.asg_name_override : var.stack_item_label}"
-  placement_group           = "${var.placement_group}"
-  protect_from_scale_in     = "${var.protect_from_scale_in}"
-  suspended_processes       = ["${compact(var.suspended_processes)}"]
-  target_group_arns         = ["${compact(var.target_group_arns)}"]
-  termination_policies      = ["${compact(var.termination_policies)}"]
-  vpc_zone_identifier       = ["${compact(var.subnets)}"]
-  wait_for_capacity_timeout = "${length(var.wait_for_capacity_timeout) > 0 ? var.wait_for_capacity_timeout : "10m"}"
+  launch_configuration      = var.lc_id
+  max_size                  = var.max_size
+  metrics_granularity       = var.metrics_granularity
+  min_size                  = var.min_size
+  name                      = length(var.asg_name_override) > 0 ? var.asg_name_override : var.stack_item_label
+  placement_group           = var.placement_group
+  protect_from_scale_in     = var.protect_from_scale_in
+  suspended_processes       = compact(var.suspended_processes)
+  target_group_arns         = compact(var.target_group_arns)
+  termination_policies      = compact(var.termination_policies)
+  vpc_zone_identifier       = compact(var.subnets)
+  wait_for_capacity_timeout = length(var.wait_for_capacity_timeout) > 0 ? var.wait_for_capacity_timeout : "10m"
 
-  tags = "${concat(local.default_asg_tags, var.additional_asg_tags)}"
+  tags = concat(local.default_asg_tags, var.additional_asg_tags)
 }
 
 resource "aws_autoscaling_group" "asg_elb" {
-  count = "${length(var.min_elb_capacity) > 0 || length(var.wait_for_elb_capacity) > 0 ? 1 : 0}"
+  count = length(var.min_elb_capacity) > 0 || length(var.wait_for_elb_capacity) > 0 ? 1 : 0
 
-  default_cooldown          = "${length(var.default_cooldown) > 0 ? var.default_cooldown : "300"}"
-  desired_capacity          = "${length(var.desired_capacity) > 0 ? var.desired_capacity : var.min_size}"
-  enabled_metrics           = ["${compact(var.enabled_metrics)}"]
-  force_delete              = "${var.force_delete}"
-  health_check_grace_period = "${length(var.hc_grace_period) > 0 ? var.hc_grace_period : "300"}"
-  health_check_type         = "${length(var.hc_check_type) > 0 ? var.hc_check_type : "ELB"}"
-  launch_configuration      = "${var.lc_id}"
-  load_balancers            = ["${compact(var.load_balancers)}"]
-  max_size                  = "${var.max_size}"
-  metrics_granularity       = "${var.metrics_granularity}"
-  min_elb_capacity          = "${length(var.min_elb_capacity) > 0 ? var.min_elb_capacity : "0"}"
-  min_size                  = "${var.min_size}"
-  name                      = "${length(var.asg_name_override) > 0 ? var.asg_name_override : var.stack_item_label}"
-  placement_group           = "${var.placement_group}"
-  protect_from_scale_in     = "${var.protect_from_scale_in}"
-  suspended_processes       = ["${compact(var.suspended_processes)}"]
-  target_group_arns         = ["${compact(var.target_group_arns)}"]
-  termination_policies      = ["${compact(var.termination_policies)}"]
-  vpc_zone_identifier       = ["${compact(var.subnets)}"]
-  wait_for_capacity_timeout = "${length(var.wait_for_capacity_timeout) > 0 ? var.wait_for_capacity_timeout : "10m"}"
-  wait_for_elb_capacity     = "${length(var.wait_for_elb_capacity) > 0 ? var.wait_for_elb_capacity : "0"}"
+  default_cooldown          = length(var.default_cooldown) > 0 ? var.default_cooldown : "300"
+  desired_capacity          = length(var.desired_capacity) > 0 ? var.desired_capacity : var.min_size
+  enabled_metrics           = compact(var.enabled_metrics)
+  force_delete              = var.force_delete
+  health_check_grace_period = length(var.hc_grace_period) > 0 ? var.hc_grace_period : "300"
+  health_check_type         = length(var.hc_check_type) > 0 ? var.hc_check_type : "ELB"
+  launch_configuration      = var.lc_id
+  load_balancers            = compact(var.load_balancers)
+  max_size                  = var.max_size
+  metrics_granularity       = var.metrics_granularity
+  min_elb_capacity          = length(var.min_elb_capacity) > 0 ? var.min_elb_capacity : "0"
+  min_size                  = var.min_size
+  name                      = length(var.asg_name_override) > 0 ? var.asg_name_override : var.stack_item_label
+  placement_group           = var.placement_group
+  protect_from_scale_in     = var.protect_from_scale_in
+  suspended_processes       = compact(var.suspended_processes)
+  target_group_arns         = compact(var.target_group_arns)
+  termination_policies      = compact(var.termination_policies)
+  vpc_zone_identifier       = compact(var.subnets)
+  wait_for_capacity_timeout = length(var.wait_for_capacity_timeout) > 0 ? var.wait_for_capacity_timeout : "10m"
+  wait_for_elb_capacity     = length(var.wait_for_elb_capacity) > 0 ? var.wait_for_elb_capacity : "0"
 
-  tags = "${concat(local.default_asg_tags, var.additional_asg_tags)}"
+  tags = concat(local.default_asg_tags, var.additional_asg_tags)
 }
+

group/asg/outputs.tf

@@ -1,9 +1,16 @@
 # Outputs
 
 output "asg_id" {
-  value = "${coalesce(join(",",aws_autoscaling_group.asg.*.id),join(",",aws_autoscaling_group.asg_elb.*.id))}"
+  value = coalesce(
+    join(",", aws_autoscaling_group.asg.*.id),
+    join(",", aws_autoscaling_group.asg_elb.*.id),
+  )
 }
 
 output "asg_name" {
-  value = "${coalesce(join(",",aws_autoscaling_group.asg.*.name),join(",",aws_autoscaling_group.asg_elb.*.name))}"
+  value = coalesce(
+    join(",", aws_autoscaling_group.asg.*.name),
+    join(",", aws_autoscaling_group.asg_elb.*.name),
+  )
 }
+

group/asg/variables.tf

@@ -2,109 +2,110 @@
 
 ## Resource tags
 variable "stack_item_fullname" {
-  type = "string"
+  type = string
 }
 
 variable "stack_item_label" {
-  type = "string"
+  type = string
 }
 
 variable "additional_asg_tags" {
-  type    = "list"
+  type    = list(string)
   default = []
 }
 
 ## Allow override of resource naming
 variable "asg_name_override" {
-  type = "string"
+  type = string
 }
 
 variable "propagate_name_at_launch" {
-  type    = "string"
+  type    = string
   default = "true"
 }
 
 ## VPC parameters
 variable "subnets" {
-  type = "list"
+  type = list(string)
 }
 
 ## LC parameters
 variable "lc_id" {
-  type = "string"
+  type = string
 }
 
 ## ASG parameters
 
 variable "default_cooldown" {
-  type = "string"
+  type = string
 }
 
 variable "desired_capacity" {
-  type = "string"
+  type = string
 }
 
 variable "enabled_metrics" {
-  type = "list"
+  type = list(string)
 }
 
 variable "force_delete" {
-  type = "string"
+  type = string
 }
 
 variable "hc_check_type" {
-  type = "string"
+  type = string
 }
 
 variable "hc_grace_period" {
-  type = "string"
+  type = string
 }
 
 variable "max_size" {
-  type = "string"
+  type = string
 }
 
 variable "metrics_granularity" {
-  type = "string"
+  type = string
 }
 
 variable "min_size" {
-  type = "string"
+  type = string
 }
 
 variable "placement_group" {
-  type = "string"
+  type = string
 }
 
 variable "protect_from_scale_in" {
-  type = "string"
+  type = bool
 }
 
 variable "suspended_processes" {
-  type = "list"
+  type = list(string)
 }
 
 variable "termination_policies" {
-  type = "list"
+  type = list(string)
 }
 
 variable "wait_for_capacity_timeout" {
-  type = "string"
+  type = string
 }
 
 ## ELB parameters
 variable "load_balancers" {
-  type = "list"
+  type = list(string)
 }
 
 variable "min_elb_capacity" {
-  type = "string"
+  type = string
 }
 
 variable "target_group_arns" {
-  type = "list"
+  type = list(string)
 }
 
 variable "wait_for_elb_capacity" {
-  type = "string"
+  type = string
 }
+

group/asg/versions.tf

@@ -0,0 +1,4 @@
+
+terraform {
+  required_version = ">= 0.12"
+}