Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to python 3 8 #235

Merged
merged 33 commits into from
Aug 18, 2023
Merged

Switch to python 3 8 #235

merged 33 commits into from
Aug 18, 2023

Conversation

nielsbuwen
Copy link
Collaborator

Closes #233

@nielsbuwen nielsbuwen requested a review from TM90 August 17, 2023 10:26
@nielsbuwen nielsbuwen self-assigned this Aug 17, 2023
Comment on lines 238 to 239
assert first != 1
assert not (first == 1)
assert first != 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the same assert

Comment on lines 122 to 123
assert lib != 1
assert lib != 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@TM90 TM90 merged commit 3534238 into master Aug 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End support for python 3.6 and python 3.7
2 participants