Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: table filters #2227

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat: table filters #2227

wants to merge 6 commits into from
+647 −15,838

Conversation

o-az
Copy link
Member

@o-az o-az commented Jun 21, 2024 •
edited
Loading

  • can search with text from any column,
  • in the transfers table, can paste tx hash as well

CleanShot 2024-06-20 at 23 26 45

search-filter.mp4

@o-az o-az requested a review from cor as a code owner June 21, 2024 03:03
@o-az o-az temporarily deployed to app-preview June 21, 2024 03:04 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 21, 2024 •
edited
Loading

App 🤌

🌎 Deploying...
✨ Deployment complete! Take a peek over at https://4e91622d.app-1b1.pages.dev

@o-az o-az temporarily deployed to app-preview June 21, 2024 03:23 — with GitHub Actions Inactive
@o-az o-az temporarily deployed to app-preview June 21, 2024 11:26 — with GitHub Actions Inactive
cor
cor requested changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@cor cor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided in matrix to wait with this until we have an implementation that fetches from the API

@o-az
Copy link
Member Author

o-az commented Jun 21, 2024

yes 👍
I have a local version working with fetching when item not in table but I'm going to add tx simulation first then comeback to this.

@cor cor marked this pull request as draft June 23, 2024 00:14
@cor cor added the S-shelved Status: Not actively being worked on, PR/issue still open for reference label Jul 26, 2024
@cor
Copy link
Contributor

cor commented Jul 26, 2024

we'll apply #2540 and #2541 first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cor cor cor requested changes

@benluelo benluelo Awaiting requested review from benluelo benluelo will be requested when the pull request is marked ready for review benluelo is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
S-shelved Status: Not actively being worked on, PR/issue still open for reference
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@o-az @cor