Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make a few type aliases in ibc-union-spec public #3383

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make a few type aliases in ibc-union-spec public #3383

wants to merge 1 commit into from
+3 −3

Conversation

larry0x
Copy link

@larry0x larry0x commented Dec 17, 2024

we want to use them

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024

@larry0x is attempting to deploy a commit to the unionbuild Team on Vercel.

A member of the Team first needs to authorize it.

benluelo
benluelo approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@benluelo benluelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - these will be made into proper newtypes soon™️ so good to have them be public

@benluelo
Copy link
Contributor

please edit your commit message to follow conventional commits (contributing guide)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluelo benluelo benluelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larry0x @benluelo