Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrects username validator regex so it allows all valid usernames #64

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

corp-0
Copy link
Member

@corp-0 corp-0 commented Nov 4, 2023

fixes #44

Copy link

commit-lint bot commented Nov 4, 2023

Bug Fixes

  • regex for usernames not allowing some valid usernames (052ae14)

Chore

  • add development api environment for bruno collection (d94d2a0)

Contributors

corp-0

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

Copy link
Contributor

sweep-ai bot commented Nov 4, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Use ruff instead of flake8 and isort for code formatting.
  • Apply: Use snake_case for variable and function names.
  • Apply: Limit line length to 121 characters.
  • Apply: Enable bandit for security checks and add necessary ignores.
  • Apply: Avoid using debug logs or print statements in production code. Check for 'print(' or 'console.log(' in the code.
  • Apply: All commits must follow conventional commits format.
  • Apply: All PR titles must follow conventional commits format.

@corp-0 corp-0 merged commit 7a80b1d into unitystation:develop Nov 5, 2023
5 checks passed
@corp-0 corp-0 deleted the regex-issue branch November 5, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Username regex issue
1 participant