1 Add Linux Installer script #219
Conversation
on gilles request, and to avoid giving external links to people for the unix installer I created with peull, I share it in the stationhub documentation and will keep this one up to date
|
It's not safe to use submodules that aren't tied to a trusted organization. |
|
if you want the script to be regularly updated, you'll have to use |
|
Away from the security implications this entails, there are several issues with this script that makes this not viable to be merged in its current state.
|
|
1 - the users who need this script are end-users, i.e. simple users, which excludes users of arch, which is not a general public distribution. 2 - it's part of the basic commands that are run every time the pc is launched, except that here there's no interface. and very VERY often ubuntu users don't update because they forget or they lazy 3 - we've already tried curl several times, especially for macOS, and it wasn't conclusive. 4 - the "LastRelease" function doesn't work, if you know how to improve this, I'd love to hear from you. |
|
and if you're not happy, why don't you offer something better? in addition, this script adds a shortcut to the start menu, "game". |
also
I've warned you on discord that I do not respond well to that tone. If you're bothered by me reviewing my PR then grow up. |
|
steamdeck it's based on ubuntu |
SteamOS 3 is based on Arch and is what the deck uses. |
|
Okay, that's good news, I guess. |
|
i don't know what to tell you I was interested in giving you guys a solution to use the releases tags since it seems that you don't know how to use JSON files or google, but I'm no longer interested in continuing this conversation. When you grow up, I'll maybe help you later; but from now on I'm only going to give you reviews, and you need to follow it with my request changes. Also, stop using github for arguing. |
Once again, don't see aggression where there isn't any. and i take you as an example, i work on what i want, how i want, without reporting to anyone, except maybe gilles bod, and atner who don't take personally every thing i say and stay constructive. |
|
also, I've just checked the script, there's no -y on full-upgrade |
|
We offer the flatpak, which is compatible with most distros. I dont think this script is needed or wanted by anyone but you, Dae. |
https://github.com/Unitystation-fork/Unitystation-Others/blob/main/Installation-Script/UnityStationInstaller.sh in addition, flatpak doesn't create desktop shortcuts |
|
Okay, great. But we can't accept an script from outside our ecosystem. One day you guys can be mad at us and change it to do something malicious and we would have no way to know it is happening until it is too late. So accepting this PR as it is, is impossible for us. Second issue is the code is in French, so it is harder for us to maintain. Any script we officially distribute to the players must be maintainable by us. Third issue is I still don't see the need for this. Does this even handle updating version of StationHub? By far, flatpak is the best option if you want to have the launcher integrated into your desktop environment. |
but i didn't see it that way, i only assumed that nobody would update this script except me. and that i didn't want to bother with fork/branch/pr for a simple number change.
once again, I'm not asking you to remove flatpak, I'm proposing an alternative that works (or worked until 20 minutes ago). |
CL: [Remove] submodule CL: [New] Script files
…to 1-add-linux-installer-script
|
@corp-0
I wouldn't say no to a volunteer to test it under arch and debian, |
There was a problem hiding this comment.
Some suggestions for me to accept this PR:
- Change all your files to another folder, I suggest creating a
Miscat the root of the repo and inside that another folder for your installation scripts. - Remove the dependencies from the script. Try to make this work without installing any other software.
- Are you sure the
.desktopfile works in all of the other distros mentioned in the script? - Change all displayed text and comments from French to English.
- Consider adding something to update, which would just uninstall and install again.
|
|
||
| Open terminal | ||
| ```shell | ||
| wget https://raw.githubusercontent.com/Unitystation-fork/Unitystation-Others/main/Installation-Script/UnityStationInstaller.sh -O ~/UnityStationInstaller.sh; sudo chmod 750 ~/UnityStationInstaller.sh; sudo ~/UnityStationInstaller.sh |
There was a problem hiding this comment.
you are still pointing to the other repo here
There was a problem hiding this comment.
could you please make a branch for me to write in?
I could then have the right links (adding hand)
that's why i wanted to make a submodule, easier to upload without modifying the documentation (and i'm glad i learned that)
| ### Uninstall | ||
| please copy past this on your terminal Open terminal | ||
| ```shell | ||
| wget -O ~/UnitystationUnInstaller.sh https://raw.githubusercontent.com/Unitystation-fork/Unitystation-Others/main/Installation-Script/UnitystationUnInstaller.sh ; sudo chmod 750 ~/UnityStationUnInstaller.sh; sudo ~/UnityStationUnInstaller.sh |
There was a problem hiding this comment.
you are also giving 750 perms to the wrong script
There was a problem hiding this comment.
no it's the Un-installation script
but I need to edit it to add the folder ~/.config/unity3d/Unitystation
to make the uninstall command as complete as possible.
| 1) | ||
| # Commandes pour Ubuntu | ||
| apt update | ||
| apt full-upgrade |
There was a problem hiding this comment.
do not upgrade the user's system.
There was a problem hiding this comment.
as I said earlier, there is no -y
so the user is free to do Y/N if the suggested updates don't suit, it doesn't block the script.
it's more for "the sake of ", to remind the user to do his updates
don't forget that most users are lazy
There was a problem hiding this comment.
it's more for "the sake of ", to remind the user to do his updates
this is an awful justification. This script doesn't need the user to upgrade their system, do not upgrade someone's computer because you think it is best for them. Respect the user.
There was a problem hiding this comment.
Keeping your system up to date is precisely the first recommendation you should make to a user, especially if they're too lazy to do it.
and i've created this script for people who want everything to work "all-in-one", the flemmes are a parameter to take into account.
you don't seem convinced?
There was a problem hiding this comment.
The whole point of a script like this is to do one thing and one thing only, install stationhub.
We don't install firefox automatically because some people are too lazy or force them to install Arch Linux because they're too stupid, because it is not our concern what the user does with their PC and we shouldn't be changing anything about it just because we think its for the best.
| # Commandes pour Ubuntu | ||
| apt update | ||
| apt full-upgrade | ||
| apt install -y wget p7zip || handle_error |
There was a problem hiding this comment.
try to get rid of these dependencies.
All linux distros should already have installed unzip so you can use that. Same with curl instead of wget
There was a problem hiding this comment.
simple tools for simple use
curl is not installed by default on some distribution,
plus wget is perfectly suited to this use, download a script,
There was a problem hiding this comment.
# use curl or wget, depending on which one we find
curl_or_wget=$(if hash curl 2>/dev/null; then echo "curl -s"; elif hash wget 2>/dev/null; then echo "wget -qO-"; fi);
if [ -z "$curl_or_wget" ]; then
echo "Neither curl nor wget found. Installing wget." >&2
//install wget here
fi
x=$($curl_or_wget "$url")see if either is installed in the system before installing the one you prefer.
There was a problem hiding this comment.
OK, I see, a bit of a twisted approach but why not.
and why do you insist on using curl?
There was a problem hiding this comment.
I had the impression that curl is the most common found in most linux systems. I read now that both are equally common, so I think the best option is to check if the system has either before installing wget
There was a problem hiding this comment.
I wasn't basing this reflection on that.
curl being a very powerful and versatile command, it often frightens people, and rightly so.
wget is all about downloading a file.
the most powerful thing you can do with it is resume an interrupted download.
There was a problem hiding this comment.
I don't know where you got that "it frightens people" thing, but I managed to get curl working pretty quick in my own installer script and the best part is that we didn't need any external dependencies.
wget is not available on all platforms or distros, and like I've mentioned; this shell script literally doesn't need an entirely new library for it to work, especially one that can affect user security.
There was a problem hiding this comment.
wget, affected the security of user :D best joke ever ...
| wget -O /usr/share/applications/Stationhub.desktop https://raw.githubusercontent.com/Unitystation-fork/Unitystation-Others/main/Installation-Script/Unitystation.desktop || handle_error | ||
|
|
||
| # Extraction du fichier zip | ||
| unzip /usr/share/Unitystation/lin-latest.zip || handle_error |
There was a problem hiding this comment.
looks like you are using unzip here, so what do you need p7zip for?
There was a problem hiding this comment.
of memory when you want to use archive extration via a script (for example sh or py) you need p7zip
but I could be mistaken
There was a problem hiding this comment.
7zip and unzip are both valid, some distros for some reason dont' come with 7zip
There was a problem hiding this comment.
in that case, the script would also have to find if the system has either and use that, like I suggested for curl and wget
There was a problem hiding this comment.
also you can do this to check for the existence of 7zip:
echo "Looking for 7zip.."
if ! command -v 7z &> /dev/null
then
echo "7zip could not be found. Extract files manually."
case $OS in
'Linux')
xdg-open https://7-zip.org/
;;
'Windows')
msg "%username%" 7zip could not be found. Extract files manually.
start https://7-zip.org/
;;
'Mac')
open https://7-zip.org/
;;
'AIX') ;;
*) ;;
esac
exit 1
fiif ! command -v 7z &> /dev/null works on all platforms and distros + it checks if 7z is available, then it does things based on the user's OS; which can also be used to check if unzip is available as well and fall back to it.
There was a problem hiding this comment.
Your script is crap and you know it.
opening a terminal and then opening a web page, did you miss the lessons on intuitiveness and the 3-click rule or what? does na notion of "user-friendly" mean anything to you?
There was a problem hiding this comment.
You mad lol
eventually,
but you did create a script because you wanted to do what I did, as if you wanted my approval and recognition, it's a shame not to have your own ideas and have to copy others because you have no talent.
In short, gilles and bod have given me recommendations as soon as I have a bit of time, and I'm going to redo it.
However, I have to thank you, so you motivated me to improve my script to prove you wrong, =)
Sorry i don't understand, could you ad more details ?
is it that big a deal, to check that wget is correctly installed / up to date for the user?
normally yes, that's why with peull we chose /usr/share/ as it's the only folder that's common to all Unixds
ok noted
I don't understand, the new version of the station hub since the 932 doesn't update itself? |
Right now all the files are insdie a
It doesn't. Users have to delete all the files and download again to update them. |
Ok thanks you could you make a fresh branch where i can write in ? |
|
you already have a branch you own on your fork. You can do whatever you want there. Any change you make and commit will appear in this PR. |
that's exactly what's annoying me I end up with a folder in "Unitystation-other", and if that suits you (plus it will allow me to clean up) |
|
All you have to do is right click your script folder and cut. Create another folder in the root of the repo and paste there. Commit that change. |
|
Okay, Dae. There a single thing I will say here. Stop acting like that, take the feedback and improve, no need to start dumb arguments. Take our review and apply the changes, otherwise we will just reject your PR. Simple as. |
| @@ -0,0 +1,10 @@ | |||
| [Desktop Entry] | |||
| Name=UnityStation | |||
There was a problem hiding this comment.
This is a desktop entry for StationHub, not for Unitystation.
| @@ -0,0 +1,674 @@ | |||
| GNU GENERAL PUBLIC LICENSE | |||
There was a problem hiding this comment.
Why does this need to be under a separate license? IMO if you're PR-ing it to the StationHub repo, just use the StationHub license.
|
|
||
| 3) | ||
| # Commandes pour Fedora | ||
| dnf update -y |
There was a problem hiding this comment.
You said above:
as I said earlier, there is no -y
so the user is free to do Y/N if the suggested updates don't suit, it doesn't block the script.
However this DOES force a user to update their system, please do not do this.
|
|
||
| 5) | ||
| # Commandes pour CentOS | ||
| yum update -y |
Unitystation-fork#1
CL: [Add] Add Linux-install-Script
on gilles' request, and to avoid giving external links to people for the unix installer I created with peull, I share it in the stationhub documentation
and will keep this one up to date
@Fr-Dae @Peulleieoyukino