-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Scanning..." and "Failed" messages to downloads and misc changes #222
Merged
Bod9001
merged 11 commits into
unitystation:develop
from
CorruptComputer:scanning-progress
Nov 28, 2023
Merged
Add "Scanning..." and "Failed" messages to downloads and misc changes #222
Bod9001
merged 11 commits into
unitystation:develop
from
CorruptComputer:scanning-progress
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings, and set project to treat warnings as errors
corp-0
reviewed
Nov 26, 2023
corp-0
previously approved these changes
Nov 26, 2023
…fix small bug with the server view model not clearing old Downloads
I'm just trying to clean up the Codacy warnings on this PR now, but it seems like every time I resolve the warnings it has more pop up... |
…uncomment them but for now its easier to just not include them
Ok I've fixed as many as I feel like fixing, not perfect but still less than there were before. |
Bod9001
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can attempt to split this into smaller PRs, but I just started working and this is what I ended up with.
Changes:
???
here it shows these: