Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Scanning..." and "Failed" messages to downloads and misc changes #222

Merged
merged 11 commits into from
Nov 28, 2023

Conversation

CorruptComputer
Copy link
Contributor

@CorruptComputer CorruptComputer commented Nov 26, 2023

I can attempt to split this into smaller PRs, but I just started working and this is what I ended up with.

Changes:

  • Add "Scanning..." and "Failed" messages for downloads
    • image
  • Add VS Code configs so folks using that editor can debug and build the project
  • Clean up some Codacy warnings
  • Replace usages of Console.WriteLine with Log.*
  • Rename some Async methods to have Async in the name
  • Through the power of JetBrains Rider, rename all variables and fields to follow naming conventions
  • Add data context bindings to all views, this doesn't change anything about how it compiles, this is so that Rider can find the references to these variables in design mode, so instead of just showing ??? here it shows these:
    • image
  • Move a couple things over to constants files
  • Add compiler option for warnings as errors, should stop these from being introduced in the future

corp-0
corp-0 previously approved these changes Nov 26, 2023
…fix small bug with the server view model not clearing old Downloads
@CorruptComputer
Copy link
Contributor Author

I'm just trying to clean up the Codacy warnings on this PR now, but it seems like every time I resolve the warnings it has more pop up...

@CorruptComputer
Copy link
Contributor Author

Ok I've fixed as many as I feel like fixing, not perfect but still less than there were before.

@Bod9001 Bod9001 merged commit 781526c into unitystation:develop Nov 28, 2023
5 of 6 checks passed
@CorruptComputer CorruptComputer deleted the scanning-progress branch November 28, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants