Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 8 Upgrade #223 #224

Merged
merged 4 commits into from
Feb 25, 2024
Merged

.NET 8 Upgrade #223 #224

merged 4 commits into from
Feb 25, 2024

Conversation

SaileshBK
Copy link
Contributor

@SaileshBK SaileshBK commented Dec 24, 2023

fix(upgrade): Upgrade to .NET 8
fix(update): Update dotnetcore.ym

Please note it's crucial to ensure that your Visual Studio 2022 IDE is updated to the most current version (17.8+) as it supports .NET 8.0 and the SDK is installed as well.

During this Upgrade,
Error : 0
Warning: 1

Microsoft.NET.Sdk.targets(284,5): Warning NETSDK1206 : Found version-specific or distribution-specific runtime identifier(s): win7-x64, win7-x86. Affected libraries: Avalonia.Angle.Windows.Natives. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details.

@SaileshBK SaileshBK marked this pull request as draft December 24, 2023 05:07
@SaileshBK SaileshBK marked this pull request as ready for review December 24, 2023 05:07
@SaileshBK
Copy link
Contributor Author

Link to #223

UnitystationLauncher/UnitystationLauncher.csproj Outdated Show resolved Hide resolved
UnitystationLauncher.sln Show resolved Hide resolved
.github/workflows/dotnetcore.yml Outdated Show resolved Hide resolved
@corp-0
Copy link
Member

corp-0 commented Dec 24, 2023

Hey, thanks for your contribution and addressing the comments. We will need some time to study if we need to update Avalonia as well, and the impact that might have.

Happy holidays!

@SaileshBK
Copy link
Contributor Author

Hey @corp-0 I was thinking of updating all the packages as well with this upgrade if that's okay. I found that the new version of Avalonia has some breaking changes and right now I am going through those and almost done with fixes. Once I am done with all the fixes I can push those updates as well.

Happy Holidays :)

@CorruptComputer
Copy link
Contributor

Hey, sorry I had not seen your message here before starting work on #225. The upgrade from Avalonia 10.x to 11.x is not smooth at all, but I have most things resolved there and the only things left seems to be style related.

@corp-0
Copy link
Member

corp-0 commented Feb 8, 2024

The new version of Avalonia was just merged and it is causing some conflicts now. Could you take a look? If not we can fix them later.

@SaileshBK
Copy link
Contributor Author

The new version of Avalonia was just merged and it is causing some conflicts now. Could you take a look? If not we can fix them later.

Done :)

Copy link
Contributor

@CorruptComputer CorruptComputer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else with this looks good to me

UnitystationLauncher/UnitystationLauncher.csproj Outdated Show resolved Hide resolved
Copy link
Member

@corp-0 corp-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!

@corp-0 corp-0 merged commit 0c7f3b9 into unitystation:develop Feb 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants