remove blocker when updating code (aiidalab#521)

Remove the code blocker when updating code widgets.
unkcpz · Oct 21, 2023 · 7493d26 · 7493d26
1 parent 0006ac2
commit 7493d26
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/aiidalab_qe/app/submission/__init__.py b/src/aiidalab_qe/app/submission/__init__.py
@@ -89,6 +89,7 @@ def __init__(self, qe_auto_setup=True, **kwargs):
         for _, entry_point in self.code_entries.items():
             for name, code in entry_point.items():
                 self.codes[name] = code
+                code.observe(self._update_state, "value")
                 self.code_children.append(self.codes[name])
         # set default codes
         self.set_selected_codes(DEFAULT_PARAMETERS["codes"])

diff --git a/tests/test_codes.py b/tests/test_codes.py
@@ -44,6 +44,11 @@ def test_identify_submission_blockers(app):
     blockers = list(submit._identify_submission_blockers())
     assert len(blockers) == 1
     # set dos code to None, will introduce another blocker
+    dos_value = submit.codes["dos"].value
     submit.codes["dos"].value = None
     blockers = list(submit._identify_submission_blockers())
     assert len(blockers) == 2
+    # set dos code back will remove the blocker
+    submit.codes["dos"].value = dos_value
+    blockers = list(submit._identify_submission_blockers())
+    assert len(blockers) == 1