Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider fixing issues detected by repository checker #58

Closed
18 tasks
ioBroker-Bot opened this issue Aug 8, 2024 · 1 comment
Closed
18 tasks

Comments

@ioBroker-Bot
Copy link

Notification from ioBroker Check and Service Bot

Dear adapter developer,

I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter pi-hole for common errors and appropiate suggestions to keep this adapter up to date.

Please see the result of the check below.

ioBroker.pi-hole

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release
NPM

ERRORS:

  • ❗ [E026] "{'engines': {'node'>='16'}}" is required at package.json, "{'engines':{'node'>='18'}}" is recommened
  • ❗ [E033] @iobroker/adapter-core 2.6.8 specified. 3.1.4 is required as minimum, 3.1.6 is recommended. Please update dependencies at package.json
  • ❗ [E035] No devDependency declared for @iobroker/testing. Please add "@iobroker/testing":"4.1.3" to devDependencies at package.json
  • ❗ [E204] Version "1.2.0" listed at common.news at io-package.json does not exist at NPM. Please remove from news section.
  • ❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2024 Michael Schuster [email protected]" at the start of LICENSE

WARNINGS:

  • 👀 [W040] "keywords" within package.json should contain "ioBroker"
  • 👀 [W105] Missing suggested translation into uk of "common.titleLang" in io-package.json.
  • 👀 [W109] Missing suggested translation into uk of "common.desc" in io-package.json.
  • 👀 [W115] "common.tier" is required in io-package.json. Please check https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/objectsschema.md#adapter.
  • 👀 [W130] Many "common.news" found in io-package.json. Repositorybuilder will truncate at 7 news. Please remove old news.
  • 👀 [W145] Missing suggested translation into ru,pt,nl,fr,it,es,pl,uk,zh-cn of some "common.news" in io-package.json.
  • 👀 [W181] "common.license" in io-package.json is deprecated. Please define object "common.licenseInformation"
  • 👀 [W184] "common.main" is deprecated and ignored. Please remove from io-package.json. Use "main" at package.json instead.
  • 👀 [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".
  • 👀 [W184] "common.title" is deprecated and replaced by "common.titleLang". Please remove from io-package.json.
  • 👀 [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package
  • 👀 [W522] Please consider migrating to admin 5 UI (jsonConfig).
  • 👀 [W853] .npmignore found - consider using package.json object "files" instead.

Please review issues reported and consider fixing them as soon as appropiate.

Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.

Warnings reported by repository checker should be reviewed. While some warnings can be considered as a suggestion and be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.

Feel free to contact me (@ioBroker-Bot) if you have any questions or feel that an issue is incorrectly flagged.

And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.

your
ioBroker Check and Service Bot

@mcm1957 for evidence

@ioBroker-Bot
Copy link
Author

This issue has been replaced by new isse #59
This issue can be closed.

your
ioBroker Check and Service Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant