Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider fixing issues detected by repository checker #59

Closed
18 tasks
ioBroker-Bot opened this issue Aug 23, 2024 · 1 comment
Closed
18 tasks

Comments

@ioBroker-Bot
Copy link

ioBroker-Bot commented Aug 23, 2024

Notification from ioBroker Check and Service Bot

Dear adapter developer,

I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter pi-hole for common errors and appropiate suggestions to keep this adapter up to date.

This check is based the current head revisions (master / main branch) of the adapter repository

Please see the result of the check below.

ioBroker.pi-hole

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release

ERRORS:

  • ❗ [E026] "{'engines': {'node'>='16'}}" is required at package.json, "{'engines':{'node'>='18'}}" is recommened
  • ❗ [E033] @iobroker/adapter-core 2.6.8 specified. 3.1.4 is required as minimum, 3.1.6 is recommended. Please update dependencies at package.json
  • ❗ [E035] No devDependency declared for @iobroker/testing. Please add "@iobroker/testing":"4.1.3" to devDependencies at package.json
  • ❗ [E204] Version "1.2.0" listed at common.news at io-package.json does not exist at NPM. Please remove from news section.
  • ❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2024 Michael Schuster [email protected]" at the start of LICENSE

WARNINGS:

SUGGESTIONS:

  • 📌 [S522] Please consider migrating to admin 5 UI (jsonConfig).

Please review issues reported and consider fixing them as soon as appropiate.

Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.

Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.

Suggestions reported by repository checker should be reviewed. Suggestions can be ignored due to a decision of the developer but they are reported as a hint to use a configuration which might get required in future or at least is used be most adapters. Suggestions are always optional to follow.

You may start a new check at any time by adding the following comment to this issue:

@iobroker-bot recheck

Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.

Feel free to contact me (@ioBroker-Bot) if you have any questions or feel that an issue is incorrectly flagged.

And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.

your
ioBroker Check and Service Bot

@mcm1957 for evidence

Last update at Fri, 06 Sep 2024 09:49:50 GMT

@ioBroker-Bot
Copy link
Author

Issue outdated due to RECREATE request. Follow up issue #60 has been created.
This issue will be closed.

your
ioBroker Check and Service Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant