Skip to content

Commit

Permalink
Always default the uno interface to 127.0.0.1 (#99)
Browse files Browse the repository at this point in the history
Co-authored-by: Lennart Regebro <[email protected]>
  • Loading branch information
regebro and Lennart Regebro authored Jan 4, 2024
1 parent ad66ba2 commit f665d52
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
7 changes: 5 additions & 2 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
2.1 (unreleased)
----------------

- The remote didn't work for the outfile if you used port forwarding
from localhost.
- Specifying `--host-location=remote` didn't work for the outfile if you
used port forwarding from localhost.

- Always default the uno interface to 127.0.0.1, no matter what the XMLRPC
interface is.


2.0 (2023-10-19)
Expand Down
4 changes: 1 addition & 3 deletions src/unoserver/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def main():
)
parser.add_argument(
"--uno-interface",
default=None,
default="127.0.0.1",
help="The interface used by the Libreoffice UNO server",
)
parser.add_argument(
Expand Down Expand Up @@ -202,8 +202,6 @@ def main():
if args.user_installation is not None:
user_installation = Path(args.user_installation).as_uri()

if args.uno_interface is None:
args.uno_interface = args.interface
if args.uno_port == args.port:
raise RuntimeError("--port and --uno-port must be different")

Expand Down

0 comments on commit f665d52

Please sign in to comment.