Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always default the uno interface to 127.0.0.1 #99

Merged
merged 1 commit into from
Jan 4, 2024
+6 −5
Merged

Always default the uno interface to 127.0.0.1 #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
2.1 (unreleased)
----------------

- The remote didn't work for the outfile if you used port forwarding
from localhost.
- Specifying `--host-location=remote` didn't work for the outfile if you
used port forwarding from localhost.

- Always default the uno interface to 127.0.0.1, no matter what the XMLRPC
interface is.


2.0 (2023-10-19)
Expand Down
4 changes: 1 addition & 3 deletions src/unoserver/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def main():
)
parser.add_argument(
"--uno-interface",
default=None,
default="127.0.0.1",
help="The interface used by the Libreoffice UNO server",
)
parser.add_argument(
Expand Down Expand Up @@ -202,8 +202,6 @@ def main():
if args.user_installation is not None:
user_installation = Path(args.user_installation).as_uri()

if args.uno_interface is None:
args.uno_interface = args.interface
if args.uno_port == args.port:
raise RuntimeError("--port and --uno-port must be different")

Expand Down