v2: Drop IE8-IE10 support. #345
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timphillips
previously approved these changes
Jun 6, 2023
Closed
IE8-10 didn't support window.crypto.getRandomValues and our library fell back to collecting entropy from mouse/keyboard events. There was a risk it hadn't collected enough entropy, so we'd jiggle the mouse until it worked. IE11 supports getRandomValues so we shouldn't run into this error any more.
We've seen failures in Chrome 109 on Mojave where the Core#send beforeEach hook
has errored with:
global leak detected: ret_nodes
https://automate.browserstack.com/dashboard/v2/builds/d02d09eba240bfe63d5d4a38186f8b263e51448b/sessions/cf7edd2c7efa5ea1d0b8d2267290fa7bdcb0595a?auth_token=e9574e9467e1f22131acef157981aeb0791f3016cc7568e5faf4fbbf550f6402&build_token=aWYzOUl2OVQxRVBrWURhSUdKZWliZU1TV01NTStuQlNUejdRSTE1djgrWXNXWUVRZmh0d25KM3lSSHVKaC91NmFRRjRreFN6RnhMWFNsOS9pb25IM0E9PS0tejEwVU1hSlNsSHJKczZDK0Y3YjlHdz09--d2cf7eb2a908ea8939f86035ad68730cc7ea2969
I've tried to track the source of ret_nodes, but been unable to find it in our
code, our vendored code, or the test-framework dependencies in
test/unit/index.html. I think we're fine without the check.
expect is the latest version (last updated 9 years ago) and xhook 1.4 is the last version to support IE11.
timphillips
previously approved these changes
Jun 8, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
We should update "branch": "v1", in the np section too.
| </head> | ||
| <body> | ||
| <div id="mocha"></div> | ||
|
|
||
| <script src="https://unpkg.com/[email protected]/dist/xhook.js"></script> | ||
| <script src="https://unpkg.com/jquery@1.12.4/dist/jquery.js"></script> | ||
| <script src="https://unpkg.com/jquery@2.2.4/dist/jquery.js"></script> |
There was a problem hiding this comment.
The jQuery version in CONTRIBUTING.md can be bumped to v2.
Co-authored-by: Tim Phillips <[email protected]>
timphillips
approved these changes
Jun 8, 2023
|
@timphillips You might need to do the honours from here ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analysis shows these are, thankfully, unused.
Checklist
Before merging:
v2branch.v2branch onv1.After merging:
v2.v2branch.