Tidy up FlagValueSource
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces and made `Identifiable` a convenience
To better disambiguate it with other properties that might be called `name` on a type you are conforming to `FlagValueSource`.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
This PR makes a few changes to
FlagValueSourceandNonSendableFlagValueSource:flagValueSourceIDproperty instead of trying to piggy back offIdentifiable.nametoflagValueSourceNameto better disambiguate with other existing properties callednamethat a type you are trying to conform toFlagValueSourcemight have.changestoflagValueChangesto better disambiguate with other existing properties calledchangesthat a type you are trying to conform toFlagValueSourcemight have.These changes resolve some errors building with Xcode 16 but are also just being a good citizen. We shouldn't be trying to force
Identifiableon a type that just wants to be aFlagValueSourcewhen all we need is an ID we can use for managing subscriptions.This is part of the Vexil 3 alpha series.