Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log resolvedUrl #218

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Log resolvedUrl #218

merged 4 commits into from
Oct 29, 2024

Conversation

sudoryan
Copy link
Contributor

@sudoryan sudoryan commented Oct 29, 2024

Log resolvedUrl for test domain on production

@sudoryan sudoryan requested a review from qrtp October 29, 2024 15:54
@sudoryan
Copy link
Contributor Author

/gcbrun

@sudoryan sudoryan removed the request for review from qrtp October 29, 2024 15:59
@sudoryan
Copy link
Contributor Author

/gcbrun

Copy link

🎉 All your tests were successful!

We detected changes in the following:

  • UD.me frontend

@sudoryan
Copy link
Contributor Author

/gcbrun

@sudoryan sudoryan changed the title Log entire props Log resolvedUrl Oct 29, 2024
console.log('Domain profile headers output:', JSON.stringify({headers: req.headers}));
console.log(
'Profile page getServerSideProps output:',
JSON.stringify(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to log the entire props? Like...

JSON.stringify(
        {
          props,
          headers: {
            ...req.headers,
          },
        },
        null,
        2,
      ),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the props object contains some circular references that can't be stringified. I defined a few more params to print

Copy link

🎉 All your tests were successful!

We detected changes in the following:

  • UD.me frontend

@sudoryan
Copy link
Contributor Author

/gcbrun

Copy link

🎉 All your tests were successful!

We detected changes in the following:

  • UD.me frontend

@sudoryan sudoryan merged commit 442066f into main Oct 29, 2024
2 checks passed
@sudoryan sudoryan deleted the ryan/log-props branch October 29, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants