-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design activity card #1091
base: master
Are you sure you want to change the base?
Design activity card #1091
Conversation
zubhub_frontend/zubhub/src/components/categories/Categories.jsx
Outdated
Show resolved
Hide resolved
@brrkrmn what happens if we have much more creators (maybe 10 or more)? can you attempt this and make a video so we see how the hover effect works in that case? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the future we might want to move all our colors into this file (you can create a task for this if you want)
needs rebase |
pre-commit checks failed ❌❌❌ |
It'll look like what we have for +3 creators, showing 3 circles at most and indicating the number of the remaining creators. Like this: Screen.Recording.2024-02-29.at.2.04.57.PM.movThis will only be applicable when the 'team' feature is made available. I'm not sure how teams are going to look exactly but if they have their own avatars, we can use the name and avatar of the team instead of showing all the creators in the activity card. And then we can show all creators in detail in the team's page or activity details page. In that case, we should have a larger section for the creators to be able to show this many. |
pre-commit checks failed ❌❌❌ |
83593db
to
445f830
Compare
pre-commit checks failed ❌❌❌ |
445f830
to
05561d4
Compare
pre-commit checks failed ❌❌❌ |
05561d4
to
22e01fc
Compare
All pre-commit checks passed ✅✅✅ |
* fix creator profile margin * fix projects section margin * fix wider project css issues * fix eslint issues Closes #1005 Signed-off-by: Ndibe Raymond Olisaemeka <[email protected]> Co-authored-by: Ndibe Raymond Olisaemeka <[email protected]>
* create views and utils methods to recommend projects * create api function to receive recommended projects in the frontend * modify project filtering * refactor recommend projects function Issue: #1013 Signed-off-by: Ndibe Raymond Olisaemeka <[email protected]> Co-authored-by: Ndibe Raymond Olisaemeka <[email protected]>
* style page and add login card * fix misaligned login form in search results * change styles for creator search * implement no results found design * make results one row * made some major refactors Issue: #802 Signed-off-by: Ndibe Raymond Olisaemeka <[email protected]> Co-authored-by: Ndibe Raymond Olisaemeka <[email protected]>
* minor modifications to the admin model * add admin models management to admin.py * implement effective signals to handle admin models instances, addition, modification and deletion with proper cleanup Issue: #1094 Signed-off-by: Ndibe Raymond Olisaemeka <[email protected]> Co-authored-by: Ndibe Raymond Olisaemeka <[email protected]>
refactor add multiple creators section create categories component refactor the use of category colors, translation file, and rendering of the tags separate creators section into its own component add unpublished icon to card update imports
22e01fc
to
5dab8f4
Compare
@tuxology this has been rebased so we can focus on testing before merging to staging |
All pre-commit checks passed ✅✅✅ |
Summary
The activity component is redesigned according to the new proposed design .
Closes #1090
Changes
colors.js
file.Screenshots
Desktop
Mobile
Multiple Creators Demonstration
Screen.Recording.2024-01-29.at.1.06.51.PM.mov