New features to demo ota-community-edition #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d80ep08th
commented
Sep 9, 2022
d80ep08th
commented
- configured https
- new domain uptanedemo.org
- Gateway to services via dgw.uptanedemo.org
- configured https for all services: director, deviceregistry etc. - access to services via dgw.uptanedemo.org - modified bash scripts to adapt to new configuration - configured docker compose file
- nginx container to serve landing page - added configuration for server in ota-ce dir
tkfu
requested changes
Sep 9, 2022
There was a problem hiding this comment.
You can't put all this demo-server-specific stuff in here; people still need to be able to run it themselves, locally, the way you did when you were starting the project. We talked about this weeks ago: you can do it with templating, or environment variables, or whatever. It doesn't matter the method, but you can't break the self-hosted community edition/ota-lith just to make the demo server work.
Comment on lines
+1
to
+19
| server { | ||
| error_log /var/log/nginx/error.log info; | ||
| listen 7443 ssl; | ||
| server_name uptanedemo.org; | ||
| ssl_certificate /etc/ssl/gateway/server.chain.pem; | ||
| ssl_certificate_key /etc/ssl/gateway/server.key; | ||
| ssl_verify_client on; | ||
| ssl_verify_depth 10; | ||
| ssl_client_certificate /etc/ssl/gateway/ca.crt; | ||
|
|
||
| if ($ssl_client_s_dn ~ "CN=(.*)$") { | ||
| set $deviceUuid $1; | ||
| } | ||
| if ($ssl_client_s_dn !~ "CN=(.*)$") { | ||
| set $deviceUuid $ssl_client_s_dn; | ||
| } | ||
| set $deviceNamespace "default"; | ||
|
|
||
| } |
There was a problem hiding this comment.
This is unique to the demo server--it doesn't belong in this repo.
| @@ -18,7 +18,7 @@ openssl pkcs8 -topk8 -nocrypt -in "${device_dir}/pkey.ec.pem" -out "${device_dir | |||
| openssl req -new -key "${device_dir}/pkey.pem" \ | |||
| -config <(sed "s/\$ENV::DEVICE_UUID/${DEVICE_UUID}/g" "${CWD}/certs/client.cnf") \ | |||
| -out "${device_dir}/${device_id}.csr" | |||
|
|
|||
There was a problem hiding this comment.
It's generally considered polite to put whitespace/formatting changes in their own PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.