🐛 AutoMigrator: Do not create migrations if nothing to migrate #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check correct file prefixes for generated SQL files - Test the 'nothing to migrate' case - Make sure string literal in default-tag is comparable to the value stored in the database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1062 I noticed that AutoMigrator would create migration files and DB entries even when models haven't been updated and there isn't anything to migrate. This PR addresses this issue.
It also mistakenly puts non-transactional migrations in
.tx.sqlfiles and vice versa because of a wrong value being passed tocreateSQLMigrations.Finally, BunModelInspector should drop surrounding
''from string literals inbun:"default:'John Doe'"to make the value comparable to the value retrieved from the database, i.e. a Go-string"John Doe".