fix: 🐛 apply relation functions on count queries #848
Conversation
| @@ -923,6 +923,17 @@ func (q *SelectQuery) Count(ctx context.Context) (int, error) { | |||
| return 0, q.err | |||
| } | |||
|
|
|||
| if err := q.forEachInlineRelJoin(func(j *relationJoin) error { | |||
| j.applyTo(q) | |||
There was a problem hiding this comment.
It looks like this function modifies the q. Meaning that it will be applied twice when run with ScanAndCount:
- first it will be applied by Scan
- second it will be applied by Count
If that is true, then the query generation becomes racy and unsafe....
There was a problem hiding this comment.
ScanAndCount calls the unexported count function that corresponds to Count on the main branch. If I remember correctly the lines you mention do in fact modify q but they are only run when Count (not count) is called directly.
I made this PR a while ago so I might be missing something, you tell me
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. If there is no update within the next 7 days, this pr will be closed. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
fixes #597