Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #65 : hides Typescript stack trace coming from wollok-ts #95

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

fdodino
Copy link
Contributor

@fdodino fdodino commented Oct 1, 2023

Dato importante

El PR hay que mergearlo posterior al fix de wollok-ts, porque agregué tests que rompen el CI a propósito.

Objetivo

Este PR soluciona el stack trace verboso que hoy se muestra para programas, tests y REPL. En realidad mi idea era arreglarlo en wollok-ts directamente, pero por el momento tuve que separarlo en dos:

  • por un lado filtrar los frames que no tengan que ver con código custom (root o módulos de "wollok")
  • por otro lado filtrar el stack trace falopa de Typescript

Con eso tenemos este comportamiento:

image

Copy link
Contributor

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quedó piola lo que hiciste 🚀 🎸

@fdodino fdodino force-pushed the fix-#65-stack-trace-hide-vm-details branch from 807cc64 to c1b7918 Compare October 2, 2023 22:07
@fdodino fdodino merged commit 99f46dc into master Oct 3, 2023
1 check passed
@fdodino fdodino deleted the fix-#65-stack-trace-hide-vm-details branch October 3, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants