Arregla issue #185 Test con el mismo nombre #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PalumboN
approved these changes
Dec 3, 2023
| @@ -511,6 +511,15 @@ export const shouldNotUseVoidMethodAsValue = error<Send>(node => { | |||
| return !method || method.isNative() || method.isAbstract() || returnsValue(method) | |||
| }) | |||
|
|
|||
| export const shouldHaveDifferentName = error<Test>(node => { | |||
| const tests: List<Test> = match(node.parent)( | |||
| when(Describe)(describe => describe.tests), | |||
There was a problem hiding this comment.
Tampoco se deberían duplicar los describes, no? 🤔
There was a problem hiding this comment.
Sí, tenés razón. Debería ser barato agregarlo... lo meto dentro de este PR.
There was a problem hiding this comment.
Apa, ya existe un shouldNotDuplicateGlobalDefinitions y se testea que el describe no se repita (entre otras cosas, como clases, wko, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporamos validación para que dos tests no tengan el mismo nombre.
Hay que mergear el PR de language primero.