Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix super incorrecto #318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

MEUFAJ
Copy link

@MEUFAJ MEUFAJ commented Nov 30, 2024

fix #305

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (9e8acd6) to head (5f68f19).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #318   +/-   ##
=======================================
  Coverage   89.73%   89.73%           
=======================================
  Files          28       28           
  Lines        3176     3176           
  Branches      576      576           
=======================================
  Hits         2850     2850           
  Misses        170      170           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fdodino fdodino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hola @MEUFAJ ,
podrías agregar un PR con la parte de language? o sea, habría que moverse a la carpeta language y generar una branch nueva

cd language
git checkout -b fix-#305-warning-super-incorrecto
git add .
git commit -m "fix super warning incorrecto"
git push --set-upstream origin fix-#305-warning-super-incorrecto

y después abrir un PR.

Primero aprobamos ése, mergeamos language y después aprobamos éste. Muchas gracias!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning de super incorrecto
2 participants