Fix broken Master Ticket process with WalletConnect on L1 #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useWalletConnect.ts: - Removed PeerMeta state variable to reduce some state complexity since it’s not used outside of the hook definition anyway. I noticed an issue where it sometimes was returning null when it should have been set, so rather than put in a fix for this it might as well just be removed IMO. Deriving from ‘session’ when needed works as expected. ResetExecute.tsx: - Removed the WalletConnect session check from within performReticket and instead now using 2 separate useEffects to ensure correct execution based on wallet type. Other login methods shouldn’t need to wait for ‘connector’ and ‘session’, which are specific to WalletConnect. WalletConnect.tsx Metamask.jsx - Deleted these components since they’re not being used. Bridge no longer renders a tab screen for Metamask or WalletConnect. Tested successfully on mainnet with Zerion and Ledger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1124
Changes:
ResetExecute.tsx:
useWalletConnect.ts:
WalletConnect.tsx
Metamask.jsx
Tested successfully on mainnet with Zerion and Ledger.