Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type documentation #80

Open
wants to merge 13 commits into
base: pre-beta
Choose a base branch
from
Open

Add type documentation #80

wants to merge 13 commits into from

Conversation

bonbud-macryg
Copy link

Closes #68.

@bonbud-macryg
Copy link
Author

Changed pre and code CSS to make this guide legible.

I think adding a background colour to the code blocks is a requirement. I prefer having the monospace text have the background too but I'm not married to it.

bonbud-macryg
bonbud-macryg commented Jul 3, 2024
View reviewed changes
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
@bonbud-macryg bonbud-macryg mentioned this pull request Jul 5, 2024
Open
liam-fitzgerald
liam-fitzgerald reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@liam-fitzgerald liam-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
@bonbud-macryg bonbud-macryg changed the base branch from develop to pre-beta August 1, 2024 17:12
hanfel-dovned
hanfel-dovned reviewed Aug 1, 2024
View reviewed changes
Copy link

@hanfel-dovned hanfel-dovned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Half-done with this review, let's pick it up some other time

pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
pkg/arvo/neo/cod/std/src/fil/types.txt Outdated Show resolved Hide resolved
@bonbud-macryg bonbud-macryg marked this pull request as ready for review August 2, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanfel-dovned hanfel-dovned hanfel-dovned left review comments

@liam-fitzgerald liam-fitzgerald liam-fitzgerald left review comments

@tiller-tolbus tiller-tolbus Awaiting requested review from tiller-tolbus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: types need reference documentation
3 participants
@bonbud-macryg @liam-fitzgerald @hanfel-dovned