Subgizmo code is reorganized and simplified + fixes to graphical glitches #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
urholaukkarinen
commented
Jan 29, 2024
urholaukkarinen
commented
- Translation and scale subgizmos now use mostly the same code.
- Subgizmos now implement a common trait instead of SubGizmo knowing about all different implementations.
- Translation gizmo no longer breaks apart at certain angles.
- Lint changes
- GitHub workflows
Removed a lot of duplicate code from translation and scale subgizmos. Common code is now used for both picking and drawing vector- and plane-based subgizmos. Lints are now defined in Cargo.toml instead of Cranky.toml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.