Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use uproot from GitHub until release v5.3.12 #62

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

matthewfeickert
Copy link
Member

Install uproot from https://github.com/scikit-hep/uproot5/tree/aa8b94f722982c6eb418f9f32273152039836fb2 to use the fix from scikit-hep/uproot5#1280 until uproot v5.3.12 is released.

cc @alexander-held

@matthewfeickert matthewfeickert self-assigned this Aug 28, 2024
* Install uproot from
  https://github.com/scikit-hep/uproot5/tree/aa8b94f722982c6eb418f9f32273152039836fb2
  to use the fix from https://github.com/scikit-hep/uproot5/pull/ 1280 until
  uproot v5.3.12 is released.
* Need to install after the lock file as pip installs from lock files with hashes requires
  that _all_ packages in the lock file have hashes, which isn't possible when installing
  from GitHub.
@matthewfeickert matthewfeickert force-pushed the fix/patch-uproot-from-github branch from 0a2c551 to b3dc72c Compare August 28, 2024 10:27
@matthewfeickert matthewfeickert merged commit d8b24e1 into dev Aug 28, 2024
1 check passed
@matthewfeickert matthewfeickert deleted the fix/patch-uproot-from-github branch August 28, 2024 10:38
matthewfeickert added a commit that referenced this pull request Aug 28, 2024
* uproot v5.3.12 has a fix for dealing with inconclusive AwkwardForth.
   - c.f. scikit-hep/uproot5#1280
* Reverts PR #62
* Rebuild lock file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant