Somme cleanning from additionnal clippy lints #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix items in documentation is missing backticks for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown - also fix some missing intra doc links.
matching over `()` is more explicit, use `()` instead of `_` for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignored_unit_patterns
fix: unnecessary structure name repetition for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self
and mark public function as `inline`
usbalbin
approved these changes
Jun 16, 2024
|
Thank you! :) |
|
Thank you too. |
Merged
usbalbin
added a commit
that referenced
this pull request
Jun 16, 2024
## Breaking * #21 -feat(breaking): make FromIteratorFixed more generic Update `FromIteratorFixed` trait to avoid unnameable iterator type as type paramater in the trait ## Other changes * #22 - Some cleaning from additional clippy lints * #20 - fix: nightly flags and clippy warnings ## Thank you * @Daniel-Aaron-Bloom * @gwen-lg
usbalbin
added a commit
that referenced
this pull request
Jun 23, 2024
## Breaking * #21 -feat(breaking): make FromIteratorFixed more generic Update `FromIteratorFixed` trait to avoid unnameable iterator type as type paramater in the trait ## Other changes * #22 - Some cleaning from additional clippy lints * #20 - fix: nightly flags and clippy warnings * #24 - Migrate to use cargo readme * #25 - Use cargo readme in ci ## Thank you * @Daniel-Aaron-Bloom * @gwen-lg
usbalbin
added a commit
that referenced
this pull request
Jun 23, 2024
## Breaking * #21 -feat(breaking): make FromIteratorFixed more generic Update `FromIteratorFixed` trait to avoid unnameable iterator type as type paramater in the trait ## Other changes * #22 - Some cleaning from additional clippy lints * #20 - fix: nightly flags and clippy warnings * #24 - Migrate to use cargo readme * #25 - Use cargo readme in ci ## Thank you * @Daniel-Aaron-Bloom * @gwen-lg
usbalbin
added a commit
that referenced
this pull request
Jun 23, 2024
## Breaking * #21 -feat(breaking): make FromIteratorFixed more generic Update `FromIteratorFixed` trait to avoid unnameable iterator type as type paramater in the trait ## Other changes * #22 - Some cleaning from additional clippy lints * #20 - fix: nightly flags and clippy warnings * #24 - Migrate to use cargo readme * #25 - Use cargo readme in ci ## Thank you * @Daniel-Aaron-Bloom * @gwen-lg
usbalbin
added a commit
that referenced
this pull request
Jun 23, 2024
## Breaking * #21 -feat(breaking): make FromIteratorFixed more generic Update `FromIteratorFixed` trait to avoid unnameable iterator type as type paramater in the trait ## Other changes * #22 - Some cleaning from additional clippy lints * #20 - fix: nightly flags and clippy warnings * #24 - Migrate to use cargo readme * #25 - Use cargo readme in ci ## Thank you * @Daniel-Aaron-Bloom * @gwen-lg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposal of enabling additional clippy lints and the associated corrections.