-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python][treasury-report] add force-regenerate
parameter to allow for deletion of the existing treasury file before generation
#515
Merged
Merged
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
8bb7938
add pre-commit to clean up code
nowei eefc291
Merge remote-tracking branch 'origin' into nowei/pre-commit
nowei 796c465
mypy checking
nowei f3645d1
add typing to everything
nowei e80c9e2
merging
nowei cfffb2e
force regenerate
nowei 317abad
Merge remote-tracking branch 'origin' into nowei/delete-on-force-rege…
nowei 61a8c0f
oops
nowei e8f2cc3
Merge remote-tracking branch 'origin' into nowei/delete-on-force-rege…
nowei 8c84dae
shouldn't raise in case it didn't exist to begin with
nowei f7f3ab3
fix logger bind
nowei bee2c2a
[treasury-report][frontend] Add force regenerate button (#560)
nowei e46b78b
Merge branch 'main' into nowei/delete-on-force-regenerate
as1729 c1d8b0d
address Aditya's comment
nowei 16df743
attach policy to allow the lambda to delete from s3 (ty @aditya)
nowei 8cf57a6
Merge remote-tracking branch 'origin' into nowei/delete-on-force-rege…
nowei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,11 @@ | |
from pydantic import BaseModel | ||
|
||
from src.lib.logging import get_logger, reset_contextvars | ||
from src.lib.s3_helper import download_s3_object, upload_generated_file_to_s3 | ||
from src.lib.s3_helper import ( | ||
delete_file_from_s3, | ||
download_s3_object, | ||
upload_generated_file_to_s3, | ||
) | ||
from src.lib.treasury_generation_common import ( | ||
OrganizationObj, | ||
OutputFileType, | ||
|
@@ -54,6 +58,7 @@ class ProjectLambdaPayload(BaseModel): | |
ProjectType: str | ||
uploadsToAdd: Dict[AgencyId, UploadObj] | ||
uploadsToRemove: Dict[AgencyId, UploadObj] | ||
forceRegenerate: bool = False | ||
|
||
|
||
@reset_contextvars | ||
|
@@ -132,6 +137,16 @@ def process_event( | |
|
||
organization = payload.organization | ||
|
||
# If we need to force-regenerate the treasury report, we delete the treasury | ||
# report from s3 so that it starts with the template file. | ||
if payload.forceRegenerate: | ||
delete_output_file( | ||
s3_client=s3_client, | ||
organization=organization, | ||
project_use_code=project_use_code, | ||
logger=logger, | ||
) | ||
|
||
# If the treasury report file exists, download it and store the data | ||
# If it doesn't exist, download the output template | ||
|
||
|
@@ -267,6 +282,28 @@ def process_event( | |
return {"statusCode": 200, "body": "Success"} | ||
|
||
|
||
def delete_output_file( | ||
s3_client: S3Client, | ||
organization: OrganizationObj, | ||
project_use_code: str, | ||
logger: structlog.stdlib.BoundLogger, | ||
): | ||
try: | ||
delete_file_from_s3( | ||
client=s3_client, | ||
bucket=os.environ["REPORTING_DATA_BUCKET_NAME"], | ||
key=get_generated_output_file_key( | ||
file_type=OutputFileType.XLSX, | ||
project=project_use_code, | ||
organization=organization, | ||
), | ||
) | ||
except ClientError as e: | ||
error = e.response.get("Error") or {} | ||
if error.get("Code") == "404": | ||
logger.exception("Expected to find an existing treasury output report") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. note: no |
||
|
||
|
||
def download_output_file( | ||
s3_client: S3Client, | ||
output_file: IO[bytes], | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we also need to delete the
report.zip
file in the same directory in addition to this fileThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file is created here: https://github.com/usdigitalresponse/cpf-reporter/blob/main/python/src/functions/create_archive.py#L104
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the list of files to delete:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added, but I'm looking into fixing the issue with the CI; (all the changed files have a
python/
prepended that needs to be removed)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed here: #575 🤞🏼