Enforce eslint plugin:vue/recommended linting and reorganize ignore l…

…ist (#2756) * Reorganize eslint ignore list by chunk of work * Fix: ensure CI doesn't auto-fix (and thus ignore) auto-fixable lint errors * Add a couple recently created files that slipped through linting in CI
usdigitalresponse · Mar 14, 2024 · 0eeef64 · 0eeef64
1 parent 8f6b29d
commit 0eeef64
Show file tree

Hide file tree

Showing 2 changed files with 75 additions and 30 deletions.
diff --git a/.github/workflows/qa.yml b/.github/workflows/qa.yml
@@ -246,7 +246,7 @@ jobs:
         env:
           CI: "true"
       - name: Run linter
-        run: yarn lint
+        run: yarn lint --no-fix
 
   tflint:
     name: Lint terraform

diff --git a/packages/client/.eslintrc.js b/packages/client/.eslintrc.js
@@ -34,65 +34,110 @@ module.exports = {
     {
       files: [
         // File list to ignore generated by `yarn run lint --no-fix --format unix | sed -E 's/:.+//g' | uniq`
-        './src/App.vue',
+        // then organized by hand into reasonable chunks of work
+
+        // ARPA Reporter: app files
         './src/arpa_reporter/App.vue',
+        './src/arpa_reporter/components/Navigation.vue',
+
+        // ARPA Reporter: basic components
         './src/arpa_reporter/components/AlertBox.vue',
         './src/arpa_reporter/components/DownloadButton.vue',
         './src/arpa_reporter/components/DownloadFileButton.vue',
         './src/arpa_reporter/components/DownloadFileButtonSmall.vue',
         './src/arpa_reporter/components/DownloadTemplateBtn.vue',
-        './src/arpa_reporter/components/Navigation.vue',
         './src/arpa_reporter/components/StandardForm.vue',
-        './src/arpa_reporter/views/Agencies.vue',
-        './src/arpa_reporter/views/Agency.vue',
+
+        // ARPA Reporter: home/login/validation views
         './src/arpa_reporter/views/Home.vue',
         './src/arpa_reporter/views/Login.vue',
+        './src/arpa_reporter/views/Validation.vue',
+
+        // ARPA Reporter: new views
         './src/arpa_reporter/views/NewTemplate.vue',
         './src/arpa_reporter/views/NewUpload.vue',
+
+        // ARPA Reporter: agency views
+        './src/arpa_reporter/views/Agencies.vue',
+        './src/arpa_reporter/views/Agency.vue',
+
+        // ARPA Reporter: reporting period views
         './src/arpa_reporter/views/ReportingPeriod.vue',
         './src/arpa_reporter/views/ReportingPeriods.vue',
+
+        // ARPA Reporter: subrecipient views
         './src/arpa_reporter/views/Subrecipient.vue',
         './src/arpa_reporter/views/Subrecipients.vue',
+
+        // ARPA Reporter: upload views
         './src/arpa_reporter/views/Upload.vue',
         './src/arpa_reporter/views/Uploads.vue',
+
+        // ARPA Reporter: user views
         './src/arpa_reporter/views/User.vue',
         './src/arpa_reporter/views/Users.vue',
-        './src/arpa_reporter/views/Validation.vue',
-        './src/components/GrantsTable.vue',
+
+        // ARPA Reporter: annual performance reporter
+        './src/views/ArpaAnnualPerformanceReporter.vue',
+
+        // Grant Finder: app files
+        './src/App.vue',
+        './src/main.js',
         './src/components/Layout.vue',
+
+        // Grant Finder: core views
+        './src/views/Home.vue',
+        './src/views/Login.vue',
+        './src/views/NotFound.vue',
+
+        // Grant Finder: grants tables
+        './src/views/Grants.vue',
+        './src/views/MyGrants.vue',
+        './src/components/GrantsTable.vue',
+
+        // Grant Finder: search modals
         './src/components/Modals/AddKeyword.vue',
-        './src/components/Modals/AddOrganization.vue',
+        './src/components/Modals/SavedSearchPanel.vue',
+        './src/components/Modals/SearchPanel.vue',
+        './src/components/SearchFilter.vue',
+
+        // Grant Finder: teams
+        './src/views/Teams.vue',
         './src/components/Modals/AddTeam.vue',
-        './src/components/Modals/AddUser.vue',
-        './src/components/Modals/EditOrganization.vue',
         './src/components/Modals/EditTeam.vue',
-        './src/components/Modals/EditUser.vue',
-        './src/components/Modals/GrantDetailsLegacy.vue',
         './src/components/Modals/ImportTeams.vue',
+        './src/components/Uploader.vue',
+
+        // Grant Finder: users
+        './src/views/Users.vue',
+        './src/components/Modals/AddUser.vue',
+        './src/components/Modals/EditUser.vue',
         './src/components/Modals/ImportUsers.vue',
+
+        // Grant Finder: organizations
+        './src/views/Organizations.vue',
+        './src/components/Modals/AddOrganization.vue',
+        './src/components/Modals/EditOrganization.vue',
+
+        // Grant Finder: grant details
+        './src/views/GrantDetails.vue',
+        './src/components/Modals/GrantDetailsLegacy.vue',
+
+        // Grant Finder: profile
+        './src/views/MyProfile.vue',
         './src/components/Modals/ProfileSettings.vue',
-        './src/components/Modals/SavedSearchPanel.vue',
-        './src/components/Modals/SearchPanel.vue',
-        './src/components/SearchFilter.vue',
-        './src/components/Uploader.vue',
         './src/components/UserAvatar.vue',
-        './src/main.js',
-        './src/views/ArpaAnnualPerformanceReporter.vue',
+
+        // Grant Finder: dashboard
         './src/views/Dashboard.vue',
-        './src/views/EligibilityCodes.vue',
-        './src/views/GrantDetails.vue',
-        './src/views/Grants.vue',
-        './src/views/Home.vue',
-        './src/views/Keywords.vue',
-        './src/views/Login.vue',
-        './src/views/MyGrants.vue',
-        './src/views/MyProfile.vue',
-        './src/views/NotFound.vue',
-        './src/views/Organizations.vue',
         './src/views/RecentActivity.vue',
-        './src/views/Teams.vue',
         './src/views/UpcomingClosingDates.vue',
-        './src/views/Users.vue',
+        './src/components/ActivityTable.vue',
+        './src/components/ClosingDatesTable.vue',
+
+        // DELETE -- no longer used
+        './src/views/EligibilityCodes.vue',
+        './src/views/Keywords.vue',
       ],
       rules: {
         // List of essential rules we previously had turned off