Update tests

usdigitalresponse · Mar 14, 2024 · 1bf6fb3 · 1bf6fb3
1 parent 83e9b17
commit 1bf6fb3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/server/__tests__/email/email.test.js b/packages/server/__tests__/email/email.test.js
@@ -194,6 +194,7 @@ describe('Email sender', () => {
             sinon.replace(emailService, 'getTransport', sinon.fake.returns({ sendEmail: sendFake }));
 
             email.deliverEmail({
+                fromName: 'Foo',
                 toAddress: '[email protected]',
                 ccAddress: '[email protected]',
                 emailHTML: '<p>foo</p>',
@@ -203,6 +204,7 @@ describe('Email sender', () => {
 
             expect(sendFake.calledOnce).to.equal(true);
             expect(sendFake.firstCall.args).to.deep.equal([{
+                fromName: 'Foo',
                 toAddress: '[email protected]',
                 ccAddress: '[email protected]',
                 subject: 'test foo email',

diff --git a/packages/server/src/lib/email/email-nodemailer.js b/packages/server/src/lib/email/email-nodemailer.js
@@ -33,7 +33,7 @@ function createTransport() {
     return nodemailer.createTransport({
         host: process.env.NODEMAILER_HOST, // e.g. 'smtp.ethereal.email'
         port: process.env.NODEMAILER_PORT, // e.g. 465
-        secure: true, // true for 465, false for other ports
+        secure: process.env.NODEMAILER_PORT === 465, // true for 465, false for other ports
         auth: {
             user: process.env.NODEMAILER_EMAIL,
             pass: process.env.NODEMAILER_EMAIL_PW,