Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: prevent changing search when results are loading" #2033

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

as1729
Copy link
Contributor

@as1729 as1729 commented Oct 5, 2023

Reverts #2025

@as1729 as1729 enabled auto-merge (squash) October 5, 2023 01:03
@as1729
Copy link
Contributor Author

as1729 commented Oct 5, 2023

@replicantSocks the reason for revert is-

  • "Edit" and "Clear" button does not work when a saved search is selected. User can click it but nothing ends up happening.

@codeclimate
Copy link

codeclimate bot commented Oct 5, 2023

Code Climate has analyzed commit 76c82e1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 56.1% (0.0% change).

View more on Code Climate.

@as1729 as1729 merged commit 9c5d9a5 into _staging Oct 5, 2023
4 checks passed
@as1729 as1729 deleted the revert-2025-disable-while-loading branch October 5, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants