fix: remove dependencies on use-request.js except from /routes #1607 #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -181,7 +181,7 @@ function recipientBelongsToUpload(existingRecipient, upload) { | |||
| * @param {object} upload - the upload record | |||
| * @returns | |||
| */ | |||
| async function updateOrCreateRecipient(existingRecipient, newRecipient, trns, upload) { | |||
| async function updateOrCreateRecipient(existingRecipient, newRecipient, trns, upload, tenantId) { | |||
There was a problem hiding this comment.
Function updateOrCreateRecipient has 5 arguments (exceeds 4 allowed). Consider refactoring.
| @@ -1,12 +1,12 @@ | |||
| const { validateUpload } = require('./validate-upload'); | |||
| const { uploadsInPeriod } = require('../db/uploads'); | |||
|
|
|||
| async function revalidateUploads(period, user, trns) { | |||
| const uploads = await uploadsInPeriod(period.id, trns); | |||
| async function revalidateUploads(period, user, req, trns, tenantId) { | |||
There was a problem hiding this comment.
Function revalidateUploads has 5 arguments (exceeds 4 allowed). Consider refactoring.
| @@ -139,7 +138,7 @@ async function createObligationSheet(periodId, domain, tenantId, logger = log) { | |||
| return rows; | |||
| } | |||
|
|
|||
| async function createProjectSummaries(periodId, domain, tenantId, logger = log) { | |||
| async function createProjectSummaries(periodId, domain, req, tenantId, logger = log) { | |||
There was a problem hiding this comment.
Function createProjectSummaries has 5 arguments (exceeds 4 allowed). Consider refactoring.
|
Code Climate has analyzed commit 91eca3f and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 38.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 55.9% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #1607
Description
This issue was recommended by @as1729 as a good "first issue" for ARPA.
This is a refactor to stop using
use-request.jsoutside of/routes, because we don't always want to assume there's a request context. This allows us to use functions without a request context by passing in the arguments they need, e.g.tenantIdTesting
The existing tests were updated to pass in necessary data where they weren't already doing that.
Automated and Unit Tests
Manual tests for Reviewer
Checklist